From c2263548ce9b8c316bf5edb51ba619409146a0b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADt=20Ku=C4=8Dera?= <26327373+vkucera@users.noreply.github.com> Date: Sat, 7 Nov 2026 18:59:59 +0100 Subject: [PATCH] Fix unused variables, parameters, values Fixes errors from the following Clang-Tidy categories: - `clang-analyzer-deadcode.DeadStores` - `clang-diagnostic-unused-parameter` - `clang-diagnostic-unused-variable` Most errors are fixed temporarily by commenting out the unused bits and by adding a `FIXME: unused` comment. The final fix is to either remove the unused bits or to fix the bugs which has to be done by someone who knows the intended behaviour. --- PWGCF/Core/CorrelationContainer.cxx | 2 +- PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx | 2 +- PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx | 4 ++-- PWGCF/Femto3D/Tasks/multEstimator.cxx | 2 +- .../FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/PWGCF/Core/CorrelationContainer.cxx b/PWGCF/Core/CorrelationContainer.cxx index 4590d9403d8..3f326c9940a 100644 --- a/PWGCF/Core/CorrelationContainer.cxx +++ b/PWGCF/Core/CorrelationContainer.cxx @@ -626,7 +626,7 @@ TH2* CorrelationContainer::getSumOfRatios(CorrelationContainer* mixed, Correlati double finiteBinCorrection = -1.0 / (2 * mTrackEtaCut) * binWidthEta / 2 + 1; LOGF(info, "Finite bin correction: %f", finiteBinCorrection); mixedNorm /= finiteBinCorrection; - mixedNormError /= finiteBinCorrection; + // mixedNormError /= finiteBinCorrection; // FIXME: unused } else { LOGF(error, "ERROR: mTrackEtaCut not set. Finite bin correction cannot be applied. Continuing anyway..."); } diff --git a/PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx b/PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx index c1bc5143b58..1cca2ee484c 100644 --- a/PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx +++ b/PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx @@ -1157,7 +1157,7 @@ struct RobustFluctuationObservables { orbitSOR = orbitSOR / nOrbitsPerTF * nOrbitsPerTF; // - 1; bcSOR = orbitSOR * nBCsPerOrbit; - magneticField = 1; + // magneticField = 1; // FIXME: unused static o2::parameters::GRPMagField* grpo = nullptr; grpo = ccdb->getForTimeStamp("GLO/Config/GRPMagField", ts); if (grpo == nullptr) { diff --git a/PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx b/PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx index 14ff6c33833..dc6f89f98c7 100644 --- a/PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx +++ b/PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx @@ -2327,7 +2327,7 @@ struct KaonIsospinFluctuations { if (!collision.has_mcCollision()) { continue; } - centrality = -1; + // centrality = -1; // FIXME: unused const auto& mcColl = collision.mcCollision(); centrality = collision.centFT0C(); @@ -2448,7 +2448,7 @@ struct KaonIsospinFluctuations { recoEvent.fill(HIST("recoEvent/ProcessType"), doSimProcessing); float centrality = -1; for (const auto& mcColl : mcCollisions) { - centrality = -1; + // centrality = -1; // FIXME: unused if (cfgVtxZCheck) { if (std::abs(mcColl.posZ()) >= cutZvertex) { diff --git a/PWGCF/Femto3D/Tasks/multEstimator.cxx b/PWGCF/Femto3D/Tasks/multEstimator.cxx index 1d6b9e845eb..aba6dd2da66 100644 --- a/PWGCF/Femto3D/Tasks/multEstimator.cxx +++ b/PWGCF/Femto3D/Tasks/multEstimator.cxx @@ -322,7 +322,7 @@ struct multEstimator { tmp_histo_per_event->Reset(); if (tmp_histo_per_event->GetEntries()) LOGF(fatal, "not cleared"); - cadidates_counter = 0; + // cadidates_counter = 0; // FIXME: unused } }; diff --git a/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx b/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx index 037c88b9837..98c085a5267 100644 --- a/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx +++ b/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx @@ -630,7 +630,7 @@ struct FemtoUniversePairTaskTrackNucleus { if (cfgProcessMP) { doSameEvent(thegroupTrack, thegroupNucleus, parts, col.magField(), col.multV0M(), 4, fillQA); - fillQA = false; + // fillQA = false; // FIXME: unused } } PROCESS_SWITCH(FemtoUniversePairTaskTrackNucleus, processSameEvent, "Enable processing same event", true); @@ -663,7 +663,7 @@ struct FemtoUniversePairTaskTrackNucleus { if (cfgProcessMP) { doSameEvent(thegroupTrack, thegroupNucleus, parts, col.magField(), col.multV0M(), 4, fillQA); - fillQA = false; + // fillQA = false; // FIXME: unused } } PROCESS_SWITCH(FemtoUniversePairTaskTrackNucleus, processSameEventMC, "Enable processing same event for Monte Carlo", false);