From 47ce03f0a43fdac7d331bf2efbe49425e1cf1dfe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADt=20Ku=C4=8Dera?= <26327373+vkucera@users.noreply.github.com> Date: Sat, 7 Nov 2026 19:00:09 +0100 Subject: [PATCH] Fix unused variables, parameters, values Fixes errors from the following Clang-Tidy categories: - `clang-analyzer-deadcode.DeadStores` - `clang-diagnostic-unused-parameter` - `clang-diagnostic-unused-variable` Most errors are fixed temporarily by commenting out the unused bits and by adding a `FIXME: unused` comment. The final fix is to either remove the unused bits or to fix the bugs which has to be done by someone who knows the intended behaviour. --- PWGLF/TableProducer/Common/zdcvector.cxx | 8 ++++---- PWGLF/TableProducer/Nuspex/pidTOFGeneric.cxx | 2 +- PWGLF/Tasks/Nuspex/NucleiEfficiencyTask.cxx | 6 +++--- PWGLF/Tasks/Nuspex/QAHistTask.cxx | 2 +- PWGLF/Tasks/Strangeness/cascpolsp.cxx | 2 +- PWGLF/Tasks/Strangeness/lambdapolsp.cxx | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/PWGLF/TableProducer/Common/zdcvector.cxx b/PWGLF/TableProducer/Common/zdcvector.cxx index ff67bf9f081..a07543d8615 100644 --- a/PWGLF/TableProducer/Common/zdcvector.cxx +++ b/PWGLF/TableProducer/Common/zdcvector.cxx @@ -449,10 +449,10 @@ struct zdcvector { } if (sumA <= 1e-4 || sumC <= 1e-4) { - qxZDCA = 0.0; - qxZDCC = 0.0; - qyZDCA = 0.0; - qyZDCC = 0.0; + // qxZDCA = 0.0; // FIXME: unused + // qxZDCC = 0.0; // FIXME: unused + // qyZDCA = 0.0; // FIXME: unused + // qyZDCC = 0.0; // FIXME: unused triggerevent = false; // zdccaltable(triggerevent, currentRunNumber, centrality, vx, vy, vz, 0.0, 0.0, 0.0, 0.0); fillTables(triggerevent, 0.f, 0.f, 0.f, 0.f); diff --git a/PWGLF/TableProducer/Nuspex/pidTOFGeneric.cxx b/PWGLF/TableProducer/Nuspex/pidTOFGeneric.cxx index 7f9a02892f5..8af356d4b91 100644 --- a/PWGLF/TableProducer/Nuspex/pidTOFGeneric.cxx +++ b/PWGLF/TableProducer/Nuspex/pidTOFGeneric.cxx @@ -246,7 +246,7 @@ struct pidTOFGeneric { // Reset the event time eventTime = 0.f; sumOfWeights = 0.f; - weight = 0.f; + // weight = 0.f; // FIXME: unused // Remove the bias on TOF ev. time if constexpr (kRemoveTOFEvTimeBias) { evTimeMakerTOF.removeBias(trk, nGoodTracksForTOF, t0TOF[0], t0TOF[1], 2); diff --git a/PWGLF/Tasks/Nuspex/NucleiEfficiencyTask.cxx b/PWGLF/Tasks/Nuspex/NucleiEfficiencyTask.cxx index f4b9b94a9cb..e7001f7e836 100644 --- a/PWGLF/Tasks/Nuspex/NucleiEfficiencyTask.cxx +++ b/PWGLF/Tasks/Nuspex/NucleiEfficiencyTask.cxx @@ -333,7 +333,7 @@ struct NucleiEfficiencyTask { pdgbin = 13; break; default: - pdgbin = -10; + // pdgbin = -10; // FIXME: unused continue; break; } @@ -453,7 +453,7 @@ struct NucleiEfficiencyTask { pdgbin = 13; break; default: - pdgbin = -10; + // pdgbin = -10; // FIXME: unused continue; break; } @@ -539,7 +539,7 @@ struct NucleiEfficiencyTask { pdgbin = 13; break; default: - pdgbin = -10; + // pdgbin = -10; // FIXME: unused continue; break; } diff --git a/PWGLF/Tasks/Nuspex/QAHistTask.cxx b/PWGLF/Tasks/Nuspex/QAHistTask.cxx index c8ebb7ca97f..f6997f52f17 100644 --- a/PWGLF/Tasks/Nuspex/QAHistTask.cxx +++ b/PWGLF/Tasks/Nuspex/QAHistTask.cxx @@ -737,7 +737,7 @@ struct QAHistTask { lorentzVector_particle_MC.SetPtEtaPhiM(track.pt() * 2.0, track.eta(), track.phi(), constants::physics::MassAlpha); break; default: - pdgbin = -10; + // pdgbin = -10; // FIXME: unused continue; break; } diff --git a/PWGLF/Tasks/Strangeness/cascpolsp.cxx b/PWGLF/Tasks/Strangeness/cascpolsp.cxx index 123f9605154..09e3406b7da 100644 --- a/PWGLF/Tasks/Strangeness/cascpolsp.cxx +++ b/PWGLF/Tasks/Strangeness/cascpolsp.cxx @@ -423,7 +423,7 @@ struct cascpolsp { } int taga = LambdaTag; - int tagb = aLambdaTag; + int tagb{}; // = aLambdaTag; // FIXME: unused if (LambdaTag) { Lambda = Proton + AntiPion; diff --git a/PWGLF/Tasks/Strangeness/lambdapolsp.cxx b/PWGLF/Tasks/Strangeness/lambdapolsp.cxx index 45d7fd49b01..41411125a1d 100644 --- a/PWGLF/Tasks/Strangeness/lambdapolsp.cxx +++ b/PWGLF/Tasks/Strangeness/lambdapolsp.cxx @@ -1851,7 +1851,7 @@ struct lambdapolsp { continue; int taga = LambdaTag; - int tagb = aLambdaTag; + int tagb{}; // = aLambdaTag; // FIXME: unused if (useAccCorr) { accprofileL = ccdb->getForTimeStamp(ConfAccPathL.value, bc.timestamp()); @@ -2220,7 +2220,7 @@ struct lambdapolsp { } int taga = LambdaTag; - int tagb = aLambdaTag; + int tagb{}; // = aLambdaTag; // FIXME: unused int tagc = K0sTag; if (analyzeK0s && K0sTag) {