From eeecbb11e669f5cc01fa781e766b5991d1d84a5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADt=20Ku=C4=8Dera?= <26327373+vkucera@users.noreply.github.com> Date: Sat, 7 Nov 2026 19:00:12 +0100 Subject: [PATCH 1/2] Fix unused variables, parameters, values Fixes errors from the following Clang-Tidy categories: - `clang-analyzer-deadcode.DeadStores` - `clang-diagnostic-unused-parameter` - `clang-diagnostic-unused-variable` Most errors are fixed temporarily by commenting out the unused bits and by adding a `FIXME: unused` comment. The final fix is to either remove the unused bits or to fix the bugs which has to be done by someone who knows the intended behaviour. --- PWGMM/Lumi/Tasks/lumiStability.cxx | 22 +++++++++---------- PWGMM/Lumi/macros/merger.C | 2 +- PWGMM/Lumi/macros/non_fac.C | 3 ++- .../ambiguousTrackPropagation.cxx | 4 ++-- PWGMM/Mult/Tasks/dndeta-hi.cxx | 2 +- PWGMM/Mult/Tasks/vertexing-fwd.cxx | 2 +- 6 files changed, 18 insertions(+), 17 deletions(-) diff --git a/PWGMM/Lumi/Tasks/lumiStability.cxx b/PWGMM/Lumi/Tasks/lumiStability.cxx index ab1dca52f6e..7df9b90ff31 100644 --- a/PWGMM/Lumi/Tasks/lumiStability.cxx +++ b/PWGMM/Lumi/Tasks/lumiStability.cxx @@ -276,11 +276,11 @@ struct LumiStabilityTask { int executionCounter = 0; int nbin = o2::constants::lhc::LHCMaxBunches; uint32_t nOrbitsPerTF = 0; // 128 in 2022, 32 in 2023 - if (is2022Data) { - nOrbitsPerTF = 128; // 128 in 2022, 32 in 2023 - } else { - nOrbitsPerTF = 32; // 128 in 2022, 32 in 2023 - } + // if (is2022Data) { + // nOrbitsPerTF = 128; // 128 in 2022, 32 in 2023 // FIXME: unused + // } else { + // nOrbitsPerTF = 32; // 128 in 2022, 32 in 2023 // FIXME: unused + // } int runNumber = bcs.iteratorAt(0).runNumber(); if (runNumber != lastRunNumber && executionCounter < 1) { tsSOR = 0; @@ -497,8 +497,8 @@ struct LumiStabilityTask { pastActivityFDDVertex |= (vertexPast); } } - deltaIndex = 0; - deltaBC = 0; + // deltaIndex = 0; // FIXME: unused + // deltaBC = 0; // FIXME: unused if (pastActivityFDDVertex == false) { histos.fill(HIST("FDD/hCounts"), 2); @@ -645,8 +645,8 @@ struct LumiStabilityTask { pastActivityFDDTriggerCCoincidenceC |= (triggerCPast & isCoinCPast); } } - deltaIndex = 0; - deltaBC = 0; + // deltaIndex = 0; // FIXME: unused + // deltaBC = 0; // FIXME: unused if (pastActivityFDDVertexCoincidences == false) { histos.fill(HIST("FDD/hCounts"), 4); @@ -782,8 +782,8 @@ struct LumiStabilityTask { pastActivityFT0TriggerC |= triggerCPast; } } - deltaIndex = 0; - deltaBC = 0; + // deltaIndex = 0; // FIXME: unused + // deltaBC = 0; // FIXME: unused histos.fill(HIST("FT0/hCounts"), 1); if (pastActivityFT0Vertex == false) { diff --git a/PWGMM/Lumi/macros/merger.C b/PWGMM/Lumi/macros/merger.C index 1ad2cd5f920..02aa16e5f03 100644 --- a/PWGMM/Lumi/macros/merger.C +++ b/PWGMM/Lumi/macros/merger.C @@ -30,7 +30,7 @@ void merger() TFile* fout = new TFile("mergedOutput.root", "recreate"); TTree* tin = new TTree("EventInfo_merged", ""); - TList* list = fin->GetListOfKeys(); + // TList* list = fin->GetListOfKeys(); // FIXME: unused TIter next(fin->GetListOfKeys()); ULong64_t fTimeStamp; diff --git a/PWGMM/Lumi/macros/non_fac.C b/PWGMM/Lumi/macros/non_fac.C index ea858e409f0..a9822bc2526 100644 --- a/PWGMM/Lumi/macros/non_fac.C +++ b/PWGMM/Lumi/macros/non_fac.C @@ -45,7 +45,7 @@ double tmax; int Countig; -void chi2(Int_t& npar, Double_t* gin, Double_t& f, Double_t* par, Int_t flag) +void chi2(Int_t& /*npar*/, Double_t* /*gin*/, Double_t& f, Double_t* par, Int_t /*flag*/) { TMatrixD sigma(2, 2); double results = 0.; @@ -241,4 +241,5 @@ void non_fac() for (int i = 0; i < 10; i++) { hParam[i]->Write(); } + fout->Close(); } diff --git a/PWGMM/Mult/TableProducer/ambiguousTrackPropagation.cxx b/PWGMM/Mult/TableProducer/ambiguousTrackPropagation.cxx index af3a895eec3..2c14f75d51e 100644 --- a/PWGMM/Mult/TableProducer/ambiguousTrackPropagation.cxx +++ b/PWGMM/Mult/TableProducer/ambiguousTrackPropagation.cxx @@ -292,7 +292,7 @@ struct AmbiguousTrackPropagation { o2::track::TrackParCovFwd bestTrackPar; for (auto const& atrack : atracks) { - dcaInfo = 999; // DCAxy + // dcaInfo = 999; // DCAxy // FIXME: unused bestDCA = 999; auto track = atrack.mfttrack(); @@ -375,7 +375,7 @@ struct AmbiguousTrackPropagation { o2::track::TrackParCovFwd bestTrackPar; for (auto const& track : tracks) { - dcaInfo = 999; // DCAxy + // dcaInfo = 999; // DCAxy // FIXME: unused bestDCA = 999; auto bestCol = track.has_collision() ? track.collisionId() : -1; diff --git a/PWGMM/Mult/Tasks/dndeta-hi.cxx b/PWGMM/Mult/Tasks/dndeta-hi.cxx index 630922994cb..f898924600e 100644 --- a/PWGMM/Mult/Tasks/dndeta-hi.cxx +++ b/PWGMM/Mult/Tasks/dndeta-hi.cxx @@ -835,7 +835,7 @@ struct MultiplicityCounter { auto pTrack = v0.template posTrack_as(); auto nTrack = v0.template negTrack_as(); - if (0 && v0.v0radius() > v0radius && + if (0 && v0.v0radius() > v0radius && // FIXME: always false v0.v0cosPA() > v0cospa && abs(pTrack.eta()) < etadau && abs(nTrack.eta()) < etadau) { diff --git a/PWGMM/Mult/Tasks/vertexing-fwd.cxx b/PWGMM/Mult/Tasks/vertexing-fwd.cxx index f5dd786acc7..66a588057b6 100644 --- a/PWGMM/Mult/Tasks/vertexing-fwd.cxx +++ b/PWGMM/Mult/Tasks/vertexing-fwd.cxx @@ -148,7 +148,7 @@ struct vertexingfwd { for (auto& atrack : atracks) { - dcaXY = 999; // DCAxy + // dcaXY = 999; // DCAxy // FIXME: unused bestDCA = 999; auto track = atrack.mfttrack_as(); From 1abbab2949dc9948b36e2daa66bc593ac1ff9232 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADt=20Ku=C4=8Dera?= <26327373+vkucera@users.noreply.github.com> Date: Mon, 9 Nov 2026 11:12:05 +0100 Subject: [PATCH 2/2] More fixes for the new ROOT --- PWGMM/Lumi/Tasks/LumiFDDFT0.cxx | 2 +- PWGMM/Lumi/Tasks/lumi.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PWGMM/Lumi/Tasks/LumiFDDFT0.cxx b/PWGMM/Lumi/Tasks/LumiFDDFT0.cxx index 629c2a7078d..6a4fa937154 100644 --- a/PWGMM/Lumi/Tasks/LumiFDDFT0.cxx +++ b/PWGMM/Lumi/Tasks/LumiFDDFT0.cxx @@ -226,7 +226,7 @@ struct LumiFDDFT0 { Pvtx.setCov(collision.covXX(), collision.covXY(), collision.covYY(), collision.covXZ(), collision.covYZ(), collision.covZZ()); // configure PVertexer - o2::dataformats::VertexBase PVbase_recalculated; + // o2::dataformats::VertexBase PVbase_recalculated; // FIXME: unused o2::vertexing::PVertexer vertexer; o2::conf::ConfigurableParam::updateFromString( "pvertexer.useMeanVertexConstraint=false"); // we want to refit w/o diff --git a/PWGMM/Lumi/Tasks/lumi.cxx b/PWGMM/Lumi/Tasks/lumi.cxx index b1fcd5910d5..66078d9a975 100644 --- a/PWGMM/Lumi/Tasks/lumi.cxx +++ b/PWGMM/Lumi/Tasks/lumi.cxx @@ -179,7 +179,7 @@ struct lumiTask { collision.covXZ(), collision.covYZ(), collision.covZZ()); // configure PVertexer - o2::dataformats::VertexBase PVbase_recalculated; + // o2::dataformats::VertexBase PVbase_recalculated; // FIXME: unused o2::vertexing::PVertexer vertexer; o2::conf::ConfigurableParam::updateFromString(