From 3234e75fe001f7e012d204220a0cf8b12dc4cb34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9on=20Avic=20Simmons?= Date: Fri, 23 Oct 2026 03:48:22 -0400 Subject: [PATCH] Fix Tutorial PrintJSON type mapping and Javadoc typos MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit APPrintJsonType.Tutorial was annotated @SerializedName("entrance_name"), which is a JSONMessagePart type rather than a PrintJSON type. The server sends type "Tutorial" (docs/network protocol.md), so those messages were deserialized as null and reported as Unknown. Also fix the POWER operation doc (copied from MULTIPLY), a missing possessive, and two sentences missing their article in EventManager. Signed-off-by: Léon Avic Simmons --- src/main/java/io/github/archipelagomw/EventManager.java | 4 ++-- .../java/io/github/archipelagomw/Print/APPrintJsonType.java | 2 +- .../io/github/archipelagomw/network/client/SetPacket.java | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/io/github/archipelagomw/EventManager.java b/src/main/java/io/github/archipelagomw/EventManager.java index 93336fb..38aa9e4 100644 --- a/src/main/java/io/github/archipelagomw/EventManager.java +++ b/src/main/java/io/github/archipelagomw/EventManager.java @@ -19,7 +19,7 @@ public class EventManager { /** * Use to register for Events that come from the Archipelago server. - * supplied Object must have at least 1 method annotated with {@link ArchipelagoEventListener} + * The supplied Object must have at least 1 method annotated with {@link ArchipelagoEventListener} * and have 1 parameter that extends {@link Event} * @param listener the object containing a listener method. */ @@ -34,7 +34,7 @@ public void registerListener(Object listener) { /** * Use to unregister for Events that come from the Archipelago server. - * supplied Object must have at least 1 method annotated with {@link ArchipelagoEventListener} + * The supplied Object must have at least 1 method annotated with {@link ArchipelagoEventListener} * and have 1 parameter that extends {@link Event} * @param listener the object containing a listener method. */ diff --git a/src/main/java/io/github/archipelagomw/Print/APPrintJsonType.java b/src/main/java/io/github/archipelagomw/Print/APPrintJsonType.java index 4c6e6d4..3922fe4 100644 --- a/src/main/java/io/github/archipelagomw/Print/APPrintJsonType.java +++ b/src/main/java/io/github/archipelagomw/Print/APPrintJsonType.java @@ -49,7 +49,7 @@ public enum APPrintJsonType { /** * The client has triggered a tutorial message, such as when first connecting. */ - @SerializedName("entrance_name") + @SerializedName("Tutorial") Tutorial, /** diff --git a/src/main/java/io/github/archipelagomw/network/client/SetPacket.java b/src/main/java/io/github/archipelagomw/network/client/SetPacket.java index 6ce5468..b613d02 100644 --- a/src/main/java/io/github/archipelagomw/network/client/SetPacket.java +++ b/src/main/java/io/github/archipelagomw/network/client/SetPacket.java @@ -61,7 +61,7 @@ public int getRequestID() { } /** - * A DataStorageOperation manipulates or alters the value of a key in the servers data storage. + * A DataStorageOperation manipulates or alters the value of a key in the server's data storage. * If the operation transforms the value from one state to another then the current value * of the key is used as the starting point otherwise the Set's package default is used if * the key does not exist on the server already. DataStorageOperations consist of an object @@ -125,7 +125,7 @@ public enum Operation { MULTIPLY, /** - * Multiplies the current value of the key on the server to the power of @value. + * Raises the current value of the key on the server to the power of @value. */ @SerializedName("pow") POWER,