From 91397203441e879a0a742e151ce560c4b7f1ebad Mon Sep 17 00:00:00 2001 From: maximsemenov Date: Tue, 10 Nov 2026 14:05:32 -0800 Subject: [PATCH 1/2] ci: run CredScan and break the build on findings Add a CredScan job to the build pipeline, with Post Analysis so unsuppressed credential findings fail the build. CredScan is required of every team by the SDL static analysis requirement, and the old classic SDL pipeline that ran it for this repo has been disabled since 2023. TSA bug filing is not used; the requirement accepts a build break instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- vsts/build.yaml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/vsts/build.yaml b/vsts/build.yaml index a44675320..94a5eb487 100644 --- a/vsts/build.yaml +++ b/vsts/build.yaml @@ -61,6 +61,31 @@ jobs: verbosity: 'Verbose' alertWarningLevel: 'High' +# CredScan is required of every team by the SDL static analysis requirement. +# Post Analysis breaks the build on unsuppressed findings (the requirement +# accepts a build break in place of TSA bug filing). Test fixtures with fake +# secrets are listed in credscan_suppression.json. +- job: 'CredScan' + displayName: 'CredScan' + pool: + vmImage: 'windows-2022' + + steps: + - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@3 + displayName: 'Run CredScan' + inputs: + toolMajorVersion: 'V2' + suppressionsFile: 'credscan_suppression.json' + debugMode: false + + - task: securedevelopmentteam.vss-secure-development-tools.build-task-publishsecurityanalysislogs.PublishSecurityAnalysisLogs@3 + displayName: 'Publish Security Analysis Logs' + + - task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@2 + displayName: 'Post Analysis' + inputs: + CredScan: true + - job: 'Publish' pool: vmImage: 'ubuntu-24.04' From 2ca15d2db581bca23c47d14f193bfcee3724840f Mon Sep 17 00:00:00 2001 From: maximsemenov Date: Thu, 12 Nov 2026 11:14:43 -0800 Subject: [PATCH 2/2] ci: scope Post Analysis to CredScan with the PostAnalysis@2 inputs PostAnalysis@2 does not have a "CredScan" input, so it was silently ignored and the step included every tool in its break filter. Set GdnBreakAllTools: false and GdnBreakGdnToolCredScan: true so only CredScan results break the build, as intended. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- vsts/build.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vsts/build.yaml b/vsts/build.yaml index 94a5eb487..5d50b657a 100644 --- a/vsts/build.yaml +++ b/vsts/build.yaml @@ -84,7 +84,8 @@ jobs: - task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@2 displayName: 'Post Analysis' inputs: - CredScan: true + GdnBreakAllTools: false + GdnBreakGdnToolCredScan: true - job: 'Publish' pool: