diff --git a/.github/workflows/bitcoin-core-fixtures.yml b/.github/workflows/bitcoin-core-fixtures.yml index 565a47b4..9a1eeacb 100644 --- a/.github/workflows/bitcoin-core-fixtures.yml +++ b/.github/workflows/bitcoin-core-fixtures.yml @@ -18,9 +18,9 @@ permissions: contents: read env: - BITCOIN_CORE_ARCHIVE: bitcoin-32.0rc2-x86_64-linux-gnu.tar.gz - BITCOIN_CORE_SHA256: 0255103718033e6aee15fa944717fc277e047b845bff1e7408af0ea732d8d0c1 - BITCOIN_CORE_URL: https://bitcoincore.org/bin/bitcoin-core-32.0/test.rc2 + BITCOIN_CORE_ARCHIVE: bitcoin-32.1-x86_64-linux-gnu.tar.gz + BITCOIN_CORE_SHA256: 61545c17c3120fb7412f896d248b11993af04ec8817aad3649c55b2afb044963 + BITCOIN_CORE_URL: https://bitcoincore.org/bin/bitcoin-core-32.1 jobs: verify: @@ -41,7 +41,7 @@ jobs: env: PYTHONPATH: ${{ github.workspace }}/src run: | - core="$RUNNER_TEMP/bitcoin-32.0rc2/bin" + core="$RUNNER_TEMP/bitcoin-32.1/bin" "$core/bitcoind" --version | head -1 python tools/bitcoin_core_regtest.py \ --bitcoind "$core/bitcoind" \ diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a0ab1f96..75b5a40d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -100,6 +100,18 @@ any users mentioned in the description will be annoyingly notified each time a fork copies the merge. Instead, make any username mentions in a subsequent comment to the PR. +### Links to Upstream Documentation + +Link to maintained upstream tutorials and user guides on their `master` branch +rather than pinning them to a release tag. For example, link Bitcoin Core's +offline-signing and multisig tutorials on `master` so readers see updated +instructions. Check that the guidance still applies to supported software. + +Use a tag or commit link when documenting version-specific behavior or +preserving historical/auditable evidence. Keep executable downloads, checksums, +dependencies, and test fixtures pinned and independently verified; live +links to documentation must not weaken those reproducibility requirements. + ### Work in Progress Changes and Requests for Comments If a pull request is not to be considered for merging (yet), please diff --git a/docs/developer/api.md b/docs/developer/api.md index 51c9fb5c..702c5f1f 100644 --- a/docs/developer/api.md +++ b/docs/developer/api.md @@ -653,10 +653,10 @@ xprv through `bitcoin-cli -stdin`, asks Core to create account-0 descriptors, and relocks an encrypted destination after success, failure, or interruption. It never handles a passphrase. -For offline signing/watch-only and multisig workflows, use Bitcoin Core v32's -maintained procedures. Until the final v32 release, see the versioned -[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/offline-signing-tutorial.md) -and [multisig tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/multisig-tutorial.md). +For offline signing/watch-only and multisig workflows, follow Bitcoin Core's +maintained procedures: +[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/offline-signing-tutorial.md) +and [multisig tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/multisig-tutorial.md). The direct `ms32 xprv` primitive remains top-level and carries an explicit secret-root warning. diff --git a/docs/user/guide.md b/docs/user/guide.md index b875ab04..c5d49b90 100644 --- a/docs/user/guide.md +++ b/docs/user/guide.md @@ -206,7 +206,7 @@ On the offline signer, create an empty encrypted descriptor wallet with private keys enabled and run `ms32 wallet`. Keep that computer disconnected from every network while recovery text or signing keys are present. -After the signer is restored, follow Bitcoin Core v32's maintained +After the signer is restored, follow Bitcoin Core's maintained [offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/offline-signing-tutorial.md). That workflow owns the watch-only export/import and PSBT transport steps. In Bitcoin Core v32, `exportwatchonlywallet` creates the watch-only wallet file and @@ -263,8 +263,8 @@ results disagree, or the wallet is multisig or nonstandard. ### Multisig cosigner recovery Restore the cosigner's private Bitcoin Core wallet with `ms32 wallet`, then -follow Bitcoin Core v32's maintained -[multisig tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/multisig-tutorial.md). +follow Bitcoin Core's maintained +[multisig tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/multisig-tutorial.md). ### Card maintenance and damaged writing