From 5792e46f0e116ea9282194377090e14799dca146 Mon Sep 17 00:00:00 2001 From: codebude Date: Fri, 23 Oct 2026 09:27:41 +0200 Subject: [PATCH 1/8] Docs: explain Read again vs status-change use cases --- docs/guide/using-librislog/progress.md | 7 +++++++ docs/releases.md | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/guide/using-librislog/progress.md b/docs/guide/using-librislog/progress.md index 6e8f103d..6bdc29f6 100644 --- a/docs/guide/using-librislog/progress.md +++ b/docs/guide/using-librislog/progress.md @@ -33,3 +33,10 @@ Click the delete button next to an entry to remove it from the log. A confirmati ## Reading Percentage For books with a page count, the detail view shows your current page, total pages, reading percentage, and a visual progress bar. + +## Reading Sessions & Re-reads + +Books can be read more than once. Each reading is tracked as its own session with independent dates and progress. + +- **Read again** (book detail dialog, for finished books): starts a fresh reading today, keeping all earlier sessions and progress untouched. Use this for a genuine re-read. +- **Changing status from "read" to "currently reading"** (edit drawer): the legacy correction path. It can keep the previous finish date or clear it, and may leave the book in a "currently reading" state that still carries the old finish date. Use this only to correct a book's status, not to re-read it. diff --git a/docs/releases.md b/docs/releases.md index 8e6d70f1..16944eed 100644 --- a/docs/releases.md +++ b/docs/releases.md @@ -45,7 +45,7 @@ LibrisLog v1.10.0 adds four more metadata sources to the import search (BnF, Inv **Features** - 📖 **Multiple reading sessions per book.** Each book keeps a list of reading periods (start and finish dates) so re-reads never overwrite earlier dates. A new `reading_session` table stores them; `Book.date_started` / `Book.date_finished` remain a mirror of the current session, so every existing consumer (sorting, timeline, statistics, import/export) keeps working unchanged -- 🔁 **"Read again" action.** A ghost button in the book detail dialog starts a new reading session for a finished book. Earlier sessions and their progress stay untouched, and the progress bar resets to 0 % +- 🔁 **"Read again" action.** A ghost button in the book detail dialog starts a new reading session for a finished book. Earlier sessions and their progress stay untouched, and the progress bar resets to 0 %. This is the recommended way to re-read; changing a book's status from "read" to "currently reading" via the edit drawer is the legacy correction path and can keep the previous finish date - 📜 **Reading history.** A collapsible block in the book detail dialog lists every session (#, started, finished, status, pages) with per-row edit and delete, plus "Add a past reading" for back-filling handwritten history - 🏷️ **"read ×N" badge.** Cards, list rows and the book detail dialog show a small badge once a book has been read at least twice - 📊 **Statistics distinguish unique books from total completions.** A new "Total reads" card shows the number of completed reads (with a "N re-read books" sub-line). `books_finished_per_month/year`, the `books_per_month/year` goals, and `pages_read` now count every completion; "Pages read" in the bucket still counts each book once, so no single-session user sees any change From 5da2a56c47c8f38f905f8438cf8008213a1e0cb0 Mon Sep 17 00:00:00 2001 From: codebude Date: Fri, 23 Oct 2026 09:30:20 +0200 Subject: [PATCH 2/8] UI fixes: mirror book dates on session edit, read-count tooltip, responsive conflict dialog buttons --- frontend/src/lib/components/BookCard.svelte | 7 +++---- .../src/lib/components/BookDetailDialog.svelte | 17 +++++++++++------ .../lib/components/DateConflictDialog.svelte | 2 +- 3 files changed, 15 insertions(+), 11 deletions(-) diff --git a/frontend/src/lib/components/BookCard.svelte b/frontend/src/lib/components/BookCard.svelte index 458fa47b..cc4c3ce3 100644 --- a/frontend/src/lib/components/BookCard.svelte +++ b/frontend/src/lib/components/BookCard.svelte @@ -104,10 +104,9 @@ {$_(STATUS_LABEL_KEYS[book.reading_status])} {#if (book.read_count ?? 0) >= 2} - ×{book.read_count} + + ×{book.read_count} + {/if} diff --git a/frontend/src/lib/components/BookDetailDialog.svelte b/frontend/src/lib/components/BookDetailDialog.svelte index 070d473a..a4f1a86b 100644 --- a/frontend/src/lib/components/BookDetailDialog.svelte +++ b/frontend/src/lib/components/BookDetailDialog.svelte @@ -178,16 +178,19 @@ date_started: addSessionStarted ? fromDateTimeInputValue(addSessionStarted, tz) : null, date_finished: addSessionFinished ? fromDateTimeInputValue(addSessionFinished, tz) : null }; + let result; if (editingSessionId !== null) { - await api.books.sessions.update(book.id, editingSessionId, payload); + result = await api.books.sessions.update(book.id, editingSessionId, payload); } else { - await api.books.sessions.create(book.id, payload); + result = await api.books.sessions.create(book.id, payload); } + book = result.book; + onSave?.(result.book); addSessionOpen = false; addSessionStarted = ''; addSessionFinished = ''; editingSessionId = null; - await loadSessions(); + await loadSessionsAndProgress(); } catch (e: unknown) { toasts.add( e instanceof Error ? e.message : $_('common.actionFailed', { values: { action: $_('book.addPastReading') } }), @@ -584,9 +587,11 @@
{#if (book.read_count ?? 0) >= 2} ×{book.read_count} + class="tooltip tooltip-bottom" + data-tip={$_('book.readCount', { values: { count: book.read_count } })} + > + ×{book.read_count} + {/if} {$_(STATUS_LABEL_KEYS[book.reading_status])}
diff --git a/frontend/src/lib/components/DateConflictDialog.svelte b/frontend/src/lib/components/DateConflictDialog.svelte index e70e088b..76826f02 100644 --- a/frontend/src/lib/components/DateConflictDialog.svelte +++ b/frontend/src/lib/components/DateConflictDialog.svelte @@ -62,7 +62,7 @@

{$_(`dateConflict.${typeKey}.message`, { values: i18nValues })}

-
+
- - {#if rereadAvailable && onReread} + {:else} + {/if} +
{#if typeKey === 'startedAfterFinished' && !(rereadAvailable && onReread)}
From eaad233e1a787b011b31b4200d5eae7d7a7101f4 Mon Sep 17 00:00:00 2001 From: codebude Date: Fri, 23 Oct 2026 10:17:24 +0200 Subject: [PATCH 4/8] Conflict dialog: merge keep/use into one button when dates are equal --- .../lib/components/DateConflictDialog.svelte | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/frontend/src/lib/components/DateConflictDialog.svelte b/frontend/src/lib/components/DateConflictDialog.svelte index ff96f0ea..d16f1ba2 100644 --- a/frontend/src/lib/components/DateConflictDialog.svelte +++ b/frontend/src/lib/components/DateConflictDialog.svelte @@ -64,22 +64,27 @@

- {#if rereadAvailable && onReread} - {:else} + + {/if} + {#if rereadAvailable && onReread} + {/if} -
- {#if typeKey === 'startedAfterFinished' && !(rereadAvailable && onReread)} + {#if typeKey === 'startedAfterFinished'}

1 {$_(`dateConflict.${typeKey}.keepDesc`, { values: i18nValues })}

2 {$_(`dateConflict.${typeKey}.clearDesc`, { values: i18nValues })}

From 7e722c13c569364babcdd7e4fe87519c2628a0a8 Mon Sep 17 00:00:00 2001 From: codebude Date: Fri, 23 Oct 2026 10:23:41 +0200 Subject: [PATCH 5/8] DateConflictDialog: avoid duplicate date in message text when both dates are equal --- frontend/src/lib/components/DateConflictDialog.svelte | 6 +++++- frontend/src/lib/i18n/locales/de.json | 6 ++++-- frontend/src/lib/i18n/locales/en.json | 6 ++++-- frontend/src/lib/i18n/locales/es.json | 6 ++++-- frontend/src/lib/i18n/locales/fr.json | 6 ++++-- frontend/src/lib/i18n/locales/zh.json | 6 ++++-- 6 files changed, 25 insertions(+), 11 deletions(-) diff --git a/frontend/src/lib/components/DateConflictDialog.svelte b/frontend/src/lib/components/DateConflictDialog.svelte index d16f1ba2..564755d8 100644 --- a/frontend/src/lib/components/DateConflictDialog.svelte +++ b/frontend/src/lib/components/DateConflictDialog.svelte @@ -60,7 +60,11 @@

{$_(`dateConflict.${typeKey}.title`)}

- {$_(`dateConflict.${typeKey}.message`, { values: i18nValues })} + {#if existingDate === suggestedDate && typeKey !== 'startedAfterFinished'} + {$_(`dateConflict.${typeKey}.messageSame`, { values: { date: existingDate } })} + {:else} + {$_(`dateConflict.${typeKey}.message`, { values: i18nValues })} + {/if}

diff --git a/frontend/src/lib/i18n/locales/de.json b/frontend/src/lib/i18n/locales/de.json index 06e59c0c..44576cc5 100644 --- a/frontend/src/lib/i18n/locales/de.json +++ b/frontend/src/lib/i18n/locales/de.json @@ -342,13 +342,15 @@ "title": "Startdatum bereits gesetzt", "message": "Startdatum ist bereits gesetzt. Möchtest du {oldDate} behalten oder {newDate} als neues Startdatum setzen?", "keepOld": "{oldDate} behalten", - "useNew": "{newDate} verwenden" + "useNew": "{newDate} verwenden", + "messageSame": "Startdatum ist bereits auf {date} gesetzt." }, "finished": { "title": "Beendigungsdatum bereits gesetzt", "message": "Beendigungsdatum ist bereits gesetzt. Möchtest du {oldDate} behalten oder {newDate} als neues Beendigungsdatum setzen?", "keepOld": "{oldDate} behalten", - "useNew": "{newDate} verwenden" + "useNew": "{newDate} verwenden", + "messageSame": "Enddatum ist bereits auf {date} gesetzt." }, "startedAfterFinished": { "title": "Buch bereits beendet", diff --git a/frontend/src/lib/i18n/locales/en.json b/frontend/src/lib/i18n/locales/en.json index 0937ef6f..b42fffa2 100644 --- a/frontend/src/lib/i18n/locales/en.json +++ b/frontend/src/lib/i18n/locales/en.json @@ -342,13 +342,15 @@ "title": "Start date already set", "message": "Date started is already set. Do you want to keep {oldDate} or set {newDate} as the new date started?", "keepOld": "Keep {oldDate}", - "useNew": "Use {newDate}" + "useNew": "Use {newDate}", + "messageSame": "Date started is already set to {date}." }, "finished": { "title": "Finish date already set", "message": "Date finished is already set. Do you want to keep {oldDate} or set {newDate} as the new date finished?", "keepOld": "Keep {oldDate}", - "useNew": "Use {newDate}" + "useNew": "Use {newDate}", + "messageSame": "Date finished is already set to {date}." }, "startedAfterFinished": { "title": "Book was already finished", diff --git a/frontend/src/lib/i18n/locales/es.json b/frontend/src/lib/i18n/locales/es.json index 15114de8..0e8f291f 100644 --- a/frontend/src/lib/i18n/locales/es.json +++ b/frontend/src/lib/i18n/locales/es.json @@ -342,13 +342,15 @@ "title": "Fecha de inicio ya establecida", "message": "La fecha de inicio ya está establecida. ¿Quieres conservar {oldDate} o establecer {newDate} como nueva fecha de inicio?", "keepOld": "Conservar {oldDate}", - "useNew": "Usar {newDate}" + "useNew": "Usar {newDate}", + "messageSame": "La fecha de inicio ya está establecida en {date}." }, "finished": { "title": "Fecha de finalización ya establecida", "message": "La fecha de finalización ya está establecida. ¿Quieres conservar {oldDate} o establecer {newDate} como nueva fecha de finalización?", "keepOld": "Conservar {oldDate}", - "useNew": "Usar {newDate}" + "useNew": "Usar {newDate}", + "messageSame": "La fecha de fin ya está establecida en {date}." }, "startedAfterFinished": { "title": "El libro ya estaba terminado", diff --git a/frontend/src/lib/i18n/locales/fr.json b/frontend/src/lib/i18n/locales/fr.json index 47036cf8..01d517b8 100644 --- a/frontend/src/lib/i18n/locales/fr.json +++ b/frontend/src/lib/i18n/locales/fr.json @@ -342,13 +342,15 @@ "title": "Date de début déjà définie", "message": "La date de début est déjà définie. Veux-tu conserver {oldDate} ou définir {newDate} comme nouvelle date de début ?", "keepOld": "Conserver {oldDate}", - "useNew": "Utiliser {newDate}" + "useNew": "Utiliser {newDate}", + "messageSame": "La date de début est déjà définie sur {date}." }, "finished": { "title": "Date de fin déjà définie", "message": "La date de fin est déjà définie. Veux-tu conserver {oldDate} ou définir {newDate} comme nouvelle date de fin ?", "keepOld": "Conserver {oldDate}", - "useNew": "Utiliser {newDate}" + "useNew": "Utiliser {newDate}", + "messageSame": "La date de fin est déjà définie sur {date}." }, "startedAfterFinished": { "title": "Livre déjà terminé", diff --git a/frontend/src/lib/i18n/locales/zh.json b/frontend/src/lib/i18n/locales/zh.json index 90b8ee6e..11eebaec 100644 --- a/frontend/src/lib/i18n/locales/zh.json +++ b/frontend/src/lib/i18n/locales/zh.json @@ -342,13 +342,15 @@ "title": "开始日期已设置", "message": "开始日期已设置。你想保留 {oldDate} 还是将 {newDate} 设为新的开始日期？", "keepOld": "保留 {oldDate}", - "useNew": "使用 {newDate}" + "useNew": "使用 {newDate}", + "messageSame": "开始日期已设置为 {date}。" }, "finished": { "title": "完成日期已设置", "message": "完成日期已设置。你想保留 {oldDate} 还是将 {newDate} 设为新的完成日期？", "keepOld": "保留 {oldDate}", - "useNew": "使用 {newDate}" + "useNew": "使用 {newDate}", + "messageSame": "结束日期已设置为 {date}。" }, "startedAfterFinished": { "title": "本书已完成", From 660ed4d6a06336509b7535b1009a3a3b26f6a734 Mon Sep 17 00:00:00 2001 From: codebude Date: Fri, 23 Oct 2026 10:42:05 +0200 Subject: [PATCH 6/8] BookDrawer: disable date inputs for books with sessions (dates are mirrors) --- frontend/src/lib/components/BookDrawer.svelte | 12 ++++++++++-- frontend/src/lib/i18n/locales/de.json | 3 ++- frontend/src/lib/i18n/locales/en.json | 3 ++- frontend/src/lib/i18n/locales/es.json | 3 ++- frontend/src/lib/i18n/locales/fr.json | 3 ++- frontend/src/lib/i18n/locales/zh.json | 3 ++- 6 files changed, 20 insertions(+), 7 deletions(-) diff --git a/frontend/src/lib/components/BookDrawer.svelte b/frontend/src/lib/components/BookDrawer.svelte index 9d285de7..a60b4fa3 100644 --- a/frontend/src/lib/components/BookDrawer.svelte +++ b/frontend/src/lib/components/BookDrawer.svelte @@ -88,6 +88,8 @@ let dateFinishedHasInput = $state(false); let cover_url = $state(null); + const hasReadingSessions = $derived((book?.session_count ?? 0) > 0); + // ── Android back button: close drawer instead of navigating away ────────── let _popClosed = false; @@ -600,9 +602,12 @@ bind:value={date_started} bind:invalid={dateStartedInvalid} bind:hasInput={dateStartedHasInput} + disabled={hasReadingSessions} ariaLabel={$_('book.dateStarted')} /> - {#if dateStartedInvalid && dateStartedHasInput} + {#if hasReadingSessions} + {$_('book.datesManagedBySessions')} + {:else if dateStartedInvalid && dateStartedHasInput} {$_('error.invalidDate')} {/if} @@ -614,9 +619,12 @@ bind:value={date_finished} bind:invalid={dateFinishedInvalid} bind:hasInput={dateFinishedHasInput} + disabled={hasReadingSessions} ariaLabel={$_('book.dateFinished')} /> - {#if dateFinishedInvalid && dateFinishedHasInput} + {#if hasReadingSessions} + {$_('book.datesManagedBySessions')} + {:else if dateFinishedInvalid && dateFinishedHasInput} {$_('error.invalidDate')} {/if} diff --git a/frontend/src/lib/i18n/locales/de.json b/frontend/src/lib/i18n/locales/de.json index 44576cc5..0ff8555a 100644 --- a/frontend/src/lib/i18n/locales/de.json +++ b/frontend/src/lib/i18n/locales/de.json @@ -225,7 +225,8 @@ "sessionReread": "Erneut gelesen", "sessionDeleteConfirm": "Diese Lesesitzung und ihre Fortschrittseinträge löschen?", "sessionDelete": "Sitzung löschen", - "readCount": "{count, plural, one {1 Mal} other {# Mal}} gelesen" + "readCount": "{count, plural, one {1 Mal} other {# Mal}} gelesen", + "datesManagedBySessions": "Wird über Lesesitzungen verwaltet" }, "addModal": { "manual": "Manuell", diff --git a/frontend/src/lib/i18n/locales/en.json b/frontend/src/lib/i18n/locales/en.json index b42fffa2..38b59c0c 100644 --- a/frontend/src/lib/i18n/locales/en.json +++ b/frontend/src/lib/i18n/locales/en.json @@ -225,7 +225,8 @@ "sessionReread": "Reread", "sessionDeleteConfirm": "Delete this reading session and its progress entries?", "sessionDelete": "Delete session", - "readCount": "Read {count, plural, one {1 time} other {# times}}" + "readCount": "Read {count, plural, one {1 time} other {# times}}", + "datesManagedBySessions": "Managed via reading sessions" }, "addModal": { "manual": "Manual", diff --git a/frontend/src/lib/i18n/locales/es.json b/frontend/src/lib/i18n/locales/es.json index 0e8f291f..cb0bc044 100644 --- a/frontend/src/lib/i18n/locales/es.json +++ b/frontend/src/lib/i18n/locales/es.json @@ -225,7 +225,8 @@ "sessionReread": "Releído", "sessionDeleteConfirm": "¿Eliminar esta sesión de lectura y sus entradas de progreso?", "sessionDelete": "Eliminar sesión", - "readCount": "Leído {count, plural, one {1 vez} other {# veces}}" + "readCount": "Leído {count, plural, one {1 vez} other {# veces}}", + "datesManagedBySessions": "Gestionado mediante sesiones de lectura" }, "addModal": { "manual": "Manual", diff --git a/frontend/src/lib/i18n/locales/fr.json b/frontend/src/lib/i18n/locales/fr.json index 01d517b8..4caf232e 100644 --- a/frontend/src/lib/i18n/locales/fr.json +++ b/frontend/src/lib/i18n/locales/fr.json @@ -225,7 +225,8 @@ "sessionReread": "Relu", "sessionDeleteConfirm": "Supprimer cette session de lecture et ses entrées de progression ?", "sessionDelete": "Supprimer la session", - "readCount": "Lu {count, plural, one {1 fois} other {# fois}}" + "readCount": "Lu {count, plural, one {1 fois} other {# fois}}", + "datesManagedBySessions": "Géré via les sessions de lecture" }, "addModal": { "manual": "Manuel", diff --git a/frontend/src/lib/i18n/locales/zh.json b/frontend/src/lib/i18n/locales/zh.json index 11eebaec..ad7d0c98 100644 --- a/frontend/src/lib/i18n/locales/zh.json +++ b/frontend/src/lib/i18n/locales/zh.json @@ -225,7 +225,8 @@ "sessionReread": "重读", "sessionDeleteConfirm": "删除此阅读会话及其进度记录？", "sessionDelete": "删除会话", - "readCount": "阅读 {count} 次" + "readCount": "阅读 {count} 次", + "datesManagedBySessions": "通过阅读会话管理" }, "addModal": { "manual": "手动添加", From 04d98dfd96f1e8111b557a888e23d43dc728fde6 Mon Sep 17 00:00:00 2001 From: codebude Date: Fri, 23 Oct 2026 10:42:18 +0200 Subject: [PATCH 7/8] Docs: note dates are read-only for books with sessions --- docs/guide/using-librislog/progress.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/guide/using-librislog/progress.md b/docs/guide/using-librislog/progress.md index 6bdc29f6..046c7165 100644 --- a/docs/guide/using-librislog/progress.md +++ b/docs/guide/using-librislog/progress.md @@ -40,3 +40,5 @@ Books can be read more than once. Each reading is tracked as its own session wit - **Read again** (book detail dialog, for finished books): starts a fresh reading today, keeping all earlier sessions and progress untouched. Use this for a genuine re-read. - **Changing status from "read" to "currently reading"** (edit drawer): the legacy correction path. It can keep the previous finish date or clear it, and may leave the book in a "currently reading" state that still carries the old finish date. Use this only to correct a book's status, not to re-read it. + +For books that already have reading sessions, the start and finish dates are mirrors of the session and are read-only in the edit drawer; edit them via the reading history instead. From 8b3847cca8729d773dec6fbb7b2bc8139000ec26 Mon Sep 17 00:00:00 2001 From: codebude Date: Fri, 23 Oct 2026 10:53:42 +0200 Subject: [PATCH 8/8] Session edit modal: use AdaptiveDateInput (text input + picker) like book edit page --- .../src/lib/components/BookDetailDialog.svelte | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/frontend/src/lib/components/BookDetailDialog.svelte b/frontend/src/lib/components/BookDetailDialog.svelte index a4f1a86b..c071253a 100644 --- a/frontend/src/lib/components/BookDetailDialog.svelte +++ b/frontend/src/lib/components/BookDetailDialog.svelte @@ -5,7 +5,9 @@ import { formatDate, formatDateTime, + fromDateInputValue, fromDateTimeInputValue, + toDateInputValue, toDateTimeInputValue } from '#lib/date.js'; import { getTimezone } from '#lib/stores/timezone.js'; @@ -13,6 +15,7 @@ import { toasts } from '#lib/toasts.js'; import { formatLanguageCode } from '#lib/utils/language.js'; import { formatAuthors } from '#lib/utils/authors.js'; + import AdaptiveDateInput from './AdaptiveDateInput.svelte'; import StarRating from './StarRating.svelte'; import { Line } from 'svelte-chartjs'; import { X } from '@lucide/svelte'; @@ -175,8 +178,8 @@ try { const payload: { status: ReadingStatus; date_started: string | null; date_finished: string | null } = { status: addSessionStatus, - date_started: addSessionStarted ? fromDateTimeInputValue(addSessionStarted, tz) : null, - date_finished: addSessionFinished ? fromDateTimeInputValue(addSessionFinished, tz) : null + date_started: addSessionStarted ? fromDateInputValue(addSessionStarted, tz) : null, + date_finished: addSessionFinished ? fromDateInputValue(addSessionFinished, tz) : null }; let result; if (editingSessionId !== null) { @@ -237,8 +240,8 @@ function openEditSession(s: ReadingSession) { addSessionStatus = s.status === 'currently_reading' ? 'read' : s.status; - addSessionStarted = s.date_started ? toDateTimeInputValue(s.date_started, tz) : ''; - addSessionFinished = s.date_finished ? toDateTimeInputValue(s.date_finished, tz) : ''; + addSessionStarted = s.date_started ? toDateInputValue(s.date_started, tz) : ''; + addSessionFinished = s.date_finished ? toDateInputValue(s.date_finished, tz) : ''; editingSessionId = s.id; addSessionOpen = true; } @@ -943,11 +946,11 @@