Repository navigation
[Schema Consistency] 🔍 Schema Consistency Check - 2026-10-16 #69267
Closed
Replies: 1 comment
|
This discussion has been marked as outdated by Schema Consistency Checker. A newer discussion is available at Discussion #69633. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Overview
Found 3 inconsistencies in deprecated
work-queue-policyconfiguration. Reviewed schema, parser/compiler, documentation, and workflow usage. No critical issue established. Source was inspected read-only; only the strategy cache was updated.Key Issues
Medium — Explicit pools silently discard shorthand outstanding limits. The schema accepts
pools.default.logical-limit: 16,native-limit: 16, andoutstanding: {claims: 1, dispatches: 1}together. The compiler modifies a local copy of the default pool, then writes it back only when explicit pools are absent. Thus the configured limits remain 16 instead of the requested shorthand limits of 1. The same writeback condition discards shorthand dependency observation-age/repository changes with explicit pools. Reject ambiguous combinations or define and implement their precedence. This concerns proposed configuration; no installed Policy or historical result was altered.Low — Schema permits mutually exclusive profile forms. A complete configuration containing both
worker-profilesandpoolspasses schema validation, but the compiler explicitly rejects it withworker-profiles shorthand cannot be combined with pools. Add a schema exclusion matching the existing parser restriction.Low — Dependency duration contract differs between schema and parser. The schema rejects
max-observation-age: 1h, although the parser uses Go duration parsing and its error advertises an inclusive range through 1h. Conversely,61mpasses the schema but exceeds the compiler limit. Align accepted syntax and document where semantic duration bounds are enforced.Evidence and analysis details
Schema ↔ Parser
All source links refer to the inspected commit.
^[1-9][0-9]*(ms|s|m)$at main_workflow_schema.json:123; the compiler parses durations and enforces 1ms–1h at work_queue_policy.go:308. Synthetic schema results:1hrejected;61maccepted.Documentation Gaps
The work-queue reference correctly marks workflow policy configuration deprecated and recommends repository
aw.jsonsettings. No independent documentation defect is asserted. When resolving these legacy inconsistencies, explain rejected shorthand/explicit combinations and accepted duration syntax without promoting legacy configuration for new workflows.Workflow Violations and False Positives
The supplied diff reports no top-level workflow keys outside the schema; the additional scan included shared components and confirmed this bounded result. No workflow violation was established. The two apparent top-level struct gaps are handled via raw frontmatter:
docker-image-pull-policyinpkg/workflow/docker.go:294, andwork-queue-policyinpkg/workflow/work_queue_policy.go:184. Missing YAML struct tags alone are not evidence of unsupported fields.AWF Canonical Source Warning — Non-authoritative
The precomputed AWF comparison has
degraded: true: canonical config-source retrieval failed. No authoritative AWF drift conclusion is possible from this run. This warning is excluded from the inconsistency count; it does not warrant failing a required check, creating a drift issue, or creating a corrective pull request.Strategy Performance
strategy-6in the strategy database.Recommendations and Next Steps
worker-profilesandpools, with a schema regression case.References: §38856151565
All reactions