From 329cfb076e15942dc67c89353014dc10e43af502 Mon Sep 17 00:00:00 2001 From: Vladimir Morozov Date: Fri, 6 Nov 2026 14:34:52 -0800 Subject: [PATCH] chore: disable inherited PGO in Windows CI Disable Node.js 26's inherited PGO setting while compiling Windows addons. Its unquoted profile path otherwise breaks the addon_build test when the fixture directory contains spaces. Apply the workaround at workflow scope so nested npm builds inherit it without changing Node's build settings. Signed-off-by: Vladimir Morozov Assisted-by: Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/ci-win.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml index a0dc12140..b547c635f 100644 --- a/.github/workflows/ci-win.yml +++ b/.github/workflows/ci-win.yml @@ -4,6 +4,8 @@ on: [push, pull_request] env: PYTHON_VERSION: '3.11' + # Work around Node.js 26 leaking its PGO settings into addon builds. + npm_package_config_node_gyp_enable_pgo_use: 'false' permissions: contents: read