From f9c4de175a1963c503684770513c0316c97438ae Mon Sep 17 00:00:00 2001 From: "tom.touleron@gmail.com" Date: Wed, 21 Oct 2026 09:06:10 +0200 Subject: [PATCH 1/3] Fix funnel percentTotal text formatting --- src/traces/bar/plot.js | 2 +- test/jasmine/tests/funnel_test.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/traces/bar/plot.js b/src/traces/bar/plot.js index 60f7154cf73..2612f9a7614 100644 --- a/src/traces/bar/plot.js +++ b/src/traces/bar/plot.js @@ -1107,7 +1107,7 @@ function calcTexttemplate(fullLayout, cd, index, xa, ya) { obj.percentPrevious = cdi.difR; obj.percentPreviousLabel = Lib.formatPercent(cdi.difR); obj.percentTotal = cdi.sumR; - obj.percenTotalLabel = Lib.formatPercent(cdi.sumR); + obj.percentTotalLabel = Lib.formatPercent(cdi.sumR); } var customdata = Lib.castOption(trace, cdi.i, 'customdata'); diff --git a/test/jasmine/tests/funnel_test.js b/test/jasmine/tests/funnel_test.js index 0506aba9da3..e7c21a33a9d 100644 --- a/test/jasmine/tests/funnel_test.js +++ b/test/jasmine/tests/funnel_test.js @@ -1271,6 +1271,7 @@ describe('A funnel plot', function() { textinfo: 'value+percent initial+percent previous+percent total', }], 'text.bartext', [ ['txt: %{value}', ['txt: 3', 'txt: 2', 'txt: 1']], + ['%{percentTotal}', ['50%', '33%', '17%']], ['%{value}-%{percentInitial}-%{percentPrevious}-%{percentTotal:0.3f}', ['3-100%-100%-0.500', '2-67%-67%-0.333', '1-33%-50%-0.167']] ]); }); From 6910b1112e58e21a49969e80c223c4064b16fcd1 Mon Sep 17 00:00:00 2001 From: "tom.touleron@gmail.com" Date: Wed, 21 Oct 2026 09:29:24 +0200 Subject: [PATCH 2/3] Add draftlog for funnel percentage fix --- draftlogs/8139_fix.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/8139_fix.md diff --git a/draftlogs/8139_fix.md b/draftlogs/8139_fix.md new file mode 100644 index 00000000000..76dbdfe226c --- /dev/null +++ b/draftlogs/8139_fix.md @@ -0,0 +1 @@ + - Fix funnel percentTotal text formatting to display formatted percentages instead of raw ratios [[#8139](https://github.com/plotly/plotly.js/pull/8139)] \ No newline at end of file From 645837251bebc9dc79608536c07c243f4536aa51 Mon Sep 17 00:00:00 2001 From: Cameron DeCoster Date: Wed, 21 Oct 2026 16:02:22 -0600 Subject: [PATCH 3/3] Update draftlog --- draftlogs/8139_fix.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draftlogs/8139_fix.md b/draftlogs/8139_fix.md index 76dbdfe226c..792e8ca201b 100644 --- a/draftlogs/8139_fix.md +++ b/draftlogs/8139_fix.md @@ -1 +1 @@ - - Fix funnel percentTotal text formatting to display formatted percentages instead of raw ratios [[#8139](https://github.com/plotly/plotly.js/pull/8139)] \ No newline at end of file + - Fix funnel `percentTotal` text formatting to display formatted percentages instead of raw ratios [[#8139](https://github.com/plotly/plotly.js/pull/8139)], with thanks to @ORITOMI for the contribution!