From 3763d410679d0b96903fba228e9c915adcf4320c Mon Sep 17 00:00:00 2001 From: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> Date: Sun, 1 Nov 2026 11:37:33 +0100 Subject: [PATCH 1/3] Fix docstring equations --- pvlib/bifacial/loss_models.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pvlib/bifacial/loss_models.py b/pvlib/bifacial/loss_models.py index 4c6f0febf3..9bc7659bfa 100644 --- a/pvlib/bifacial/loss_models.py +++ b/pvlib/bifacial/loss_models.py @@ -115,8 +115,8 @@ def power_mismatch_deline( .. math:: - RMAD(k \cdot X + c) = RMAD(X) \cdot k \frac{k \bar{X}}{k \bar{X} + c} - = RMAD(X) \cdot \frac{k}{1 + \frac{c}{k \bar{X}}} + RMAD(k \cdot X + c) = RMAD(X) \frac{k \bar{X}}{k \bar{X} + c} + = RMAD(X) \cdot \frac{1}{1 + \frac{c}{k \bar{X}}} by similarity with equation (2) of [1]_: @@ -128,7 +128,7 @@ def power_mismatch_deline( .. math:: - RMAD_{total} = RMAD_{rear} \frac{\phi_{Bifi}} + RMAD_{total} = RMAD_{rear} \frac{1} {1 + \frac{G_{front}}{\phi_{Bifi} \bar{G}_{rear}}} See Also From 5cee1df30c455cb93a399fc319d029ce8f67d659 Mon Sep 17 00:00:00 2001 From: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> Date: Sun, 1 Nov 2026 11:48:50 +0100 Subject: [PATCH 2/3] Add whatsnew entry --- docs/sphinx/source/whatsnew/v0.16.2.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index 67e908862a..496059aaf0 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -21,6 +21,8 @@ Bug fixes is scalar (:issue:`2881`, :pull:`2882`) * :py:func:`pvlib.scaling.wvm` no longer returns all NaNs when ``positions`` contains a single site (:issue:`2895`, :pull:`2896`) +* Fix :py:func:`pvlib.bifacial.power_mismatch_deline` docstring's incorrect derivation + of total RMAD from rear RMAD. (:issue:`2929`, :pull:`2930`) Enhancements ~~~~~~~~~~~~ From ec045a8a41bad59e8129272c58184296ac1f7696 Mon Sep 17 00:00:00 2001 From: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> Date: Tue, 3 Nov 2026 11:34:55 +0100 Subject: [PATCH 3/3] Review: move whatsnew entry to Docs section --- docs/sphinx/source/whatsnew/v0.16.2.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index 496059aaf0..5893d8bf46 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -21,8 +21,6 @@ Bug fixes is scalar (:issue:`2881`, :pull:`2882`) * :py:func:`pvlib.scaling.wvm` no longer returns all NaNs when ``positions`` contains a single site (:issue:`2895`, :pull:`2896`) -* Fix :py:func:`pvlib.bifacial.power_mismatch_deline` docstring's incorrect derivation - of total RMAD from rear RMAD. (:issue:`2929`, :pull:`2930`) Enhancements ~~~~~~~~~~~~ @@ -33,6 +31,8 @@ Enhancements Documentation ~~~~~~~~~~~~~ +* Fix :py:func:`pvlib.bifacial.power_mismatch_deline` incorrect derivation + of total RMAD from rear RMAD. (:issue:`2929`, :pull:`2930`) * Add :py:func:`pvlib.spa.transit_sunrise_sunset` to the API reference. (:issue:`2255`, :pull:`2873`) * Clarified in :py:func:`pvlib.tracking.singleaxis` that the tracker