GPUDisplay: Cleanup and improvements (DO NOT MERGE) by davidrohr · Pull Request #16022 · AliceO2Group/AliceO2

davidrohr · 2026-10-29T02:53:32Z

No description provided.

alibuild · 2026-11-06T21:54:33Z

Error while checking build/O2/fullCI_slc9 for 6c8335b at 2026-11-08 22:18:

## sw/BUILD/O2-RTC-test-latest/log
/tmp/o2cagpu_rtc_136_1158441977_19.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_19.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_58.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_58.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_68.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_24.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_68.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_24.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_20.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_20.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_97.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_97.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_94.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_94.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_78.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_78.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_31.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_31.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_16.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_16.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_64.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_64.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_61.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_61.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_85.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_85.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_95.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_95.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_33.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_33.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_69.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_69.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_56.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_56.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_100.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_100.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_87.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_87.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_79.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_79.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_65.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_65.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_81.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_81.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_52.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_52.cu(769): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_48.cu(768): error: GPUDisplayCopyableAtomic is not a template
/tmp/o2cagpu_rtc_136_1158441977_48.cu(769): error: GPUDisplayCopyableAtomic is not a template
[0 more errors; see full log]

Full log here.

…tructure

…x file, with all code for configuration updates

…rol struct

…nd GUI

…long if/else if

… to them via add_key_binding

…ndings

…hey can be reused for the GUI

…potent

… this ptr, update key constants

…g updates instead of busy loop / sleep

…g of an animation without running an animation

…e given

… to the GUI and returning lambda functions with value updates

…d dynamically

…PUSettings struct

…iables

…tion and steering the display

…n at startup

alibuild · 2026-11-08T23:25:50Z

Error while checking build/O2/fullCI_slc9 for 1efa249 at 2026-11-09 00:25:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ echo 'Found 501 errors and 0 warnings.'
Found 501 errors and 0 warnings.
++ [[ 501 -gt 0 ]]
++ cat errors.txt
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:8:23: error: use '= default' to define a trivial default constructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:10:23: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:63:34: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:69:37: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:90:28: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:92:13: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairBaseMCGenerator.cxx:51:22: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairBaseMCGenerator.cxx:58:20: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairBoxGenerator.cxx:117:47: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairBoxGenerator.cxx:175:32: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairDetector.cxx:42:15: error: use '= default' to define a trivial copy constructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairDetector.cxx:53:22: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairEventHeader.cxx:24:18: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairField.cxx:26:12: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileHeader.cxx:41:20: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileHeader.cxx:42:26: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileHeader.cxx:50:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileHeader.cxx:53:17: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileInfo.cxx:15:10: error: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileInfo.cxx:37:15: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenerator.cxx:22:16: error: use '= default' to define a trivial copy constructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenerator.cxx:26:16: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenerator.cxx:31:22: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenerator.cxx:43:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:27:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:28:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:41:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:42:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:57:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:64:22: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:71:15: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:72:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:73:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:82:21: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:90:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:130:43: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:144:44: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:171:32: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericVMCConfig.cxx:19:23: error: use '= default' to define a trivial default constructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericVMCConfig.cxx:21:23: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGeoAsciiIo.cxx:26:10: error: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGeoAsciiIo.cxx:27:10: error: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

alibuild · 2026-11-09T00:31:25Z

Error while checking build/O2/fullCI_slc9 for 2ed2c1f at 2026-11-09 01:31:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ echo 'Found 501 errors and 0 warnings.'
Found 501 errors and 0 warnings.
++ [[ 501 -gt 0 ]]
++ cat errors.txt
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:8:23: error: use '= default' to define a trivial default constructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:10:23: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:63:34: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:69:37: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:90:28: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairAlignmentHandler.cxx:92:13: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairBaseMCGenerator.cxx:51:22: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairBaseMCGenerator.cxx:58:20: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairBoxGenerator.cxx:117:47: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairBoxGenerator.cxx:175:32: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairDetector.cxx:42:15: error: use '= default' to define a trivial copy constructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairDetector.cxx:53:22: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairEventHeader.cxx:24:18: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairField.cxx:26:12: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileHeader.cxx:41:20: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileHeader.cxx:42:26: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileHeader.cxx:50:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileHeader.cxx:53:17: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileInfo.cxx:15:10: error: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairFileInfo.cxx:37:15: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenerator.cxx:22:16: error: use '= default' to define a trivial copy constructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenerator.cxx:26:16: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenerator.cxx:31:22: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenerator.cxx:43:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:27:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:28:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:41:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:42:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:57:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:64:22: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:71:15: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:72:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:73:16: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:82:21: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:90:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:130:43: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:144:44: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericStack.cxx:171:32: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericVMCConfig.cxx:19:23: error: use '= default' to define a trivial default constructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGenericVMCConfig.cxx:21:23: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGeoAsciiIo.cxx:26:10: error: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers,-warnings-as-errors]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/3rdparty/FairRootBase/src/FairGeoAsciiIo.cxx:27:10: error: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

alibuild mentioned this pull request Oct 29, 2026

Please consider the following formatting changes to #16022 davidrohr/AliceO2#147

Open

davidrohr changed the title ~~GPUDisplay: Cleanup and improvements~~ GPUDisplay: Cleanup and improvements (DO NOT MERGE) Oct 29, 2026

davidrohr force-pushed the PR branch 4 times, most recently from 751a579 to 6c8335b Compare November 6, 2026 18:19

davidrohr force-pushed the PR branch from 6c8335b to 2ed2c1f Compare November 8, 2026 21:28

davidrohr added 22 commits November 8, 2026 23:28

GPU: remove obsolete config code

69a317b

GPU Display: Fix FPE with display width = 0, e.g. with none backend

ec2c994

GPU: Possibility to generate run time type information about config s…

4cf5418

…tructure

GPU Display: Reorganize frontend to have GPUSettingsFrontendConfig.cx…

92fa846

…x file, with all code for configuration updates

GPU Display Frontend: move key binding constants to separate header

27de674

GPU Display: Build config RTTI Structs

a2ad9a8

GPU Display: Remove mKeysShifted helper array

b0b0939

GPU Display: Assemble all variables controlling the display in a cont…

82fd9b5

…rol struct

GPU Display: Add option to list configuration bindings for keyboard a…

00ce83c

…nd GUI

GPU Display Frontend: move key handling to RTTI callbacks instead of …

824f353

…long if/else if

GPU Display Frontend: Add a map for key down actions, and assign keys…

1cf4604

… to them via add_key_binding

GPU Display: Switch help-text to auto-generated help text from key bi…

fd74233

…ndings

GPU Display: Info messages per configuration value, not per key, so t…

a87a940

…hey can be reused for the GUI

GPU Display: Unify calling DrawGLScene and handling of events

c8c6f66

GPU Display: Clean up full screen / maximized setting, make them idem…

2e8bf7f

…potent

GPU Display: Cleanup: check for config changes only once

653dd56

GPU Display backend glut: support maximizing the window

f441341

GPU Display: Modernize GLUT backend: Use callbacks with user-data for…

c260ddf

… this ptr, update key constants

GPU Display Frontend: Use condition_variable to signal stop and confi…

9d94db0

…g updates instead of busy loop / sleep

GPU Wayland Display: Fix handling of F keys

37d5fc0

GPU Display: Drop / implement some simple TODOs

573edd2

GPU Display: Fix creating unrequested screenshot, when enabling savin…

e44b44f

…g of an animation without running an animation

davidrohr added 19 commits November 8, 2026 23:28

GPU Display Frontend: auto-generate info message for key-press if non…

89d46ea

…e given

GPU Display: Order key bindings for better grouping in the help text

8ef27cb

GPU Display: Drop obsolete compat profile for OpenGL

76fd07d

GPU Display: Wrap lines of help text if they do not fit on screen

aecd797

GPU Display: Fix do not exit on arrow key presses in the console

996a6ca

GPU Display Qt GUI: Add proper passing of frames with config elements…

cff6c04

… to the GUI and returning lambda functions with value updates

GPU Display GUI: Get rid of Qt ui file, since all elements are create…

e605870

…d dynamically

GPU: Can load GPUSettingsList.h - like structs from multiple files

8388aea

GPU Config: Clean up header guards

3bed93f

GPU: Fix missing newline in RTC param code

83417f4

GPU: Improve settings handling and make GPUDisplayControl a qconfig G…

498f3a0

…PUSettings struct

GPU Display Frontend: Use RTTI for configuring GPUDisplayControl

6dd6818

GPU Display: Suppress generic SetInfo change-messages for certain var…

0d94fe5

…iables

GPUD Display: Move frontend key number constants to separate header

6c73580

GPU Display: Correctly handle special cars pressed in the console window

12db80a

GPU Display OpenGL: Ignore stale errors from the frontend

1bf74f1

GPU Display: Add an integrated console for manipulating the configura…

2aee297

…tion and steering the display

GPU Display: Improve synchronization and avoid possible race conditio…

6d223b2

…n at startup

GPU Display Console: Add the possibility to execute a script file

1efa249

davidrohr force-pushed the PR branch from 2ed2c1f to 1efa249 Compare November 8, 2026 22:30

Navigation Menu

Repository navigation

GPUDisplay: Cleanup and improvements (DO NOT MERGE) - #16022

GPUDisplay: Cleanup and improvements (DO NOT MERGE)#16022
davidrohr wants to merge 41 commits into
AliceO2Group:devfrom
davidrohr:PR

davidrohr commented Oct 29, 2026

Uh oh!

alibuild commented Nov 6, 2026 •

edited

Loading

Uh oh!

alibuild commented Nov 8, 2026

Uh oh!

alibuild commented Nov 9, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

davidrohr commented Oct 29, 2026

Uh oh!

alibuild commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Nov 8, 2026

Uh oh!

alibuild commented Nov 9, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

alibuild commented Nov 6, 2026 •

edited

Loading