Repository navigation
EMCAL: initialise the MC kinematics reader pointer in the digitizer - #16073
Merged
Merged
Conversation
DigitizerSpec::mcReader had no initialiser, and run() only creates the reader when the pointer is null. When the memory the (large) spec is allocated in is not zeroed, the reader is never created and getMCEventHeader() dereferences garbage, crashing the digitizer at the first collision accepted by the CTP minimum-bias trigger. Seen on macOS in about one run in three; Linux likely hides it because large allocations come from fresh zeroed pages. Also initialise mCTPConfig, which follows the same pattern.
Member
Author
|
Trivial and currently randomly crashing. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DigitizerSpec::mcReader had no initialiser, and run() only creates the
reader when the pointer is null. When the memory the (large) spec is
allocated in is not zeroed, the reader is never created and
getMCEventHeader() dereferences garbage, crashing the digitizer at the
first collision accepted by the CTP minimum-bias trigger. Seen on macOS
in about one run in three; Linux likely hides it because large
allocations come from fresh zeroed pages.
Also initialise mCTPConfig, which follows the same pattern.