Repository navigation
GPU Metal: relink the backend library when the kernels change - #16076
Merged
Merged
Conversation
The Metal IR is packed into the library with -sectcreate at link time, but the link step did not depend on the IR file. A change to the kernel code alone rebuilt the IR without relinking the library, which kept running the old kernels.
Member
Author
|
macOS only. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Metal IR is packed into the library with -sectcreate at link time,
but the link step did not depend on the IR file. A change to the kernel
code alone rebuilt the IR without relinking the library, which kept
running the old kernels.