Repository navigation
Conversation
The AOD reader replaces every occurrence of the aod-parent-base-path-replacement pattern in a parent file path, while metadata discovery replaced only the first one, so the two could open different files. Use the same replacement in both. An empty pattern is now ignored, as it is in the reader.
With --aod-origin-replace and --aod-origin-level-mapping, every device received the metadata of level 0, even when different files are read. Each device now sees the metadata of the level its origin maps to. - Parse and validate aod-origin-level-mapping once during discovery, into the aod-origin-level-map LabeledArray which the AOD reader now consumes. - Read each mapped level through AODInputFile, opening every file in the chain of parents only once, and forward the result as the aod-metadata-origins LabeledArray and aod-metadata-origin-<O>-tables. - Overlay the row of the origin of the process on the plain aod-metadata-* options at the end of discovery, erasing the keys which are missing at that level. - Add LabeledArray::getRow by label, and tests for the above. Without a mapping the plain options are unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard behavior without origin level mapping is unaffected. When origin level mapping is used, the AOD metadata is taken from files on corresponding levels and propagated as per-origin labeled array to the devices in the workflow. For this, the metadata retrieval is refactored to only happen once in the driver, so that files are not re-opened later. The devices themselves, if they have origin replacement enabled, will modify their ConfigParamRegistry, replacing the standard aod-metadata- values there with the ones that conform to their origin, using the per-origin map that was passed to them via command line. This permits, for example, self-configuring tasks, such as event selection service, to be left as is - they will correctly get the metadata, corresponding to their replaced origin.
Replaces #15928.