Skip to content

[PWGHF] D+-h task: Decouple pT limits in ML cuts and in correl. - #18365

Merged
apalasciano merged 5 commits into
AliceO2Group:masterfrom
apalasciano:dpcorr
Nov 6, 2026
Merged

apalasciano merged 5 commits into
AliceO2Group:masterfrom
apalasciano:dpcorr

Conversation

@apalasciano

@apalasciano apalasciano commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator
  • Decoupling limits of correlations, efficiencies and ML cuts
  • Fixing ambiguity between efficiency fetched from CCDB and from configurables
  • Not used QA histograms removed

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5ddd68f at 2026-10-20 15:37:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 22 warnings.'
Found 1 errors and 22 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/a40f92cda2566f9b56b5eba604891798c875cca6/O2Physics-code-check/errors.txt
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:49:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 22 -gt 0 ]]
++ cat /sw/BUILD/a40f92cda2566f9b56b5eba604891798c875cca6/O2Physics-code-check/warnings.txt
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:83:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:84:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:84:76: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:85:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:86:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:87:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:88:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:89:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:90:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:91:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:91:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:92:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:92:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:93:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:93:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:94:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:94:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:95:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:95:83: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:96:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:96:83: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:159:32: warning: initializer for member 'binsPtMlD' is redundant [readability-redundant-member-init]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 137f3f8 at 2026-11-05 19:33:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 21 warnings.'
Found 1 errors and 21 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/9cbc62628c2362f8c53a8a9abaa6ff42367d701a/O2Physics-code-check/errors.txt
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:192:25: error: C-style casts are discouraged; use constructor call syntax [google-readability-casting,-warnings-as-errors]
++ [[ 21 -gt 0 ]]
++ cat /sw/BUILD/9cbc62628c2362f8c53a8a9abaa6ff42367d701a/O2Physics-code-check/warnings.txt
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:82:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:83:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:83:76: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:84:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:85:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:86:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:87:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:88:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:89:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:90:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:90:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:91:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:91:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:92:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:92:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:93:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:93:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:94:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:94:83: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:95:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:95:83: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@apalasciano
apalasciano enabled auto-merge (squash) November 6, 2026 09:53

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @apalasciano.

@apalasciano
apalasciano merged commit f928d62 into AliceO2Group:master Nov 6, 2026
15 checks passed
@apalasciano
apalasciano deleted the dpcorr branch November 6, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants