[PWGDQ] Remove reinterpret_cast and add extra protections in MCH tracking eff macro by atavirag · Pull Request #18379 · AliceO2Group/O2Physics

atavirag · 2026-10-21T15:21:12Z

No description provided.

github-actions · 2026-10-21T15:21:31Z

O2 linter results: ❌ 0 errors, ⚠️ 37 warnings, 🔕 0 disabled

alibuild · 2026-10-21T16:06:18Z

Error while checking build/O2Physics/code-check for bec7267 at 2026-10-22 02:34:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 41 warnings.'
Found 2 errors and 41 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/85bf0f52a397ed5e5fa77ec23da8d23d9332f5ab/O2Physics-code-check/errors.txt
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:85:7: error: Value stored to 'nBinMinPt' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:85:7: error: unused variable 'nBinMinPt' [clang-diagnostic-unused-variable,-warnings-as-errors]
++ [[ 41 -gt 0 ]]
++ cat /sw/BUILD/85bf0f52a397ed5e5fa77ec23da8d23d9332f5ab/O2Physics-code-check/warnings.txt
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:33:67: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:34:53: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:34:76: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:35:33: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:36:31: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:73:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:88:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:93:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:119:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:124:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:125:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:130:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:138:75: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:146:74: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:156:75: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:163:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:169:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:170:47: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:173:47: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:176:47: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:181:47: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:188:42: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:194:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:206:65: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:206:78: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:215:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:217:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:219:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:231:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:241:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:251:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:264:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[0 more errors; see full log]

Full log here.

alibuild · 2026-10-21T17:16:47Z

Error while checking build/O2Physics/code-check for 19bbd3b at 2026-10-21 19:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 45 warnings.'
Found 4 errors and 45 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/15792436694f0754cbab228f1847d093ef6c8cba/O2Physics-code-check/errors.txt
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:85:7: error: Value stored to 'nBinMinPt' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:85:7: error: unused variable 'nBinMinPt' [clang-diagnostic-unused-variable,-warnings-as-errors]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:105:15: error: unused variable 'hChNames' [clang-diagnostic-unused-variable,-warnings-as-errors]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:113:15: error: unused variable 'hStNames' [clang-diagnostic-unused-variable,-warnings-as-errors]
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/15792436694f0754cbab228f1847d093ef6c8cba/O2Physics-code-check/warnings.txt
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:33:67: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:34:53: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:34:76: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:35:33: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:36:31: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:73:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:88:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:93:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:105:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:113:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:121:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:126:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:127:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:132:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:140:75: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:148:74: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:158:75: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:165:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:171:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:172:47: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:175:47: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:178:47: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:183:47: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:190:42: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:196:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:208:65: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:208:78: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:217:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:219:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Macros/evalMchTrackingEfficiency.cxx:221:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[0 more errors; see full log]

Full log here.

axti98 · 2026-11-05T13:32:25Z

@lucamicheletti93 @atavirag Is this PR still in progress?

atavirag · 2026-11-06T08:56:02Z

@lucamicheletti93 @atavirag Is this PR still in progress?

Hi, from my side it is ready to be commited, I don't plan on changing it anymore

lucamicheletti93 · 2026-11-06T09:05:10Z

@atavirag there are some conflicts in the PR, could you resolve them?

remove reinterpret_cast and add extra protections

19bbd3b

atavirag requested review from XiaozhiBai, alibuild, iarsene, mcoquet642 and mguilbau as code owners October 21, 2026 15:21

github-actions Bot added the pwgdq label Oct 21, 2026

github-actions Bot changed the title ~~[PWGDQ ]Remove reinterpret_cast and add extra protections in MCH tracking eff macro~~ [PWGDQ] [PWGDQ ]Remove reinterpret_cast and add extra protections in MCH tracking eff macro Oct 21, 2026

fix megalinter

bec7267

vkucera changed the title ~~[PWGDQ] [PWGDQ ]Remove reinterpret_cast and add extra protections in MCH tracking eff macro~~ [PWGDQ] Remove reinterpret_cast and add extra protections in MCH tracking eff macro Oct 21, 2026

fix code check errors

c3afb98

lucamicheletti93 previously approved these changes Nov 6, 2026

View reviewed changes

lucamicheletti93 enabled auto-merge (squash) November 6, 2026 09:04

Merge branch 'master' into mch-macro-fix

9068838

atavirag dismissed lucamicheletti93’s stale review via 9068838 November 6, 2026 09:13

atavirag requested review from axti98, glegras and shreyasiacharya as code owners November 6, 2026 09:13

lucamicheletti93 disabled auto-merge November 6, 2026 15:42

lucamicheletti93 enabled auto-merge (squash) November 6, 2026 15:42

lucamicheletti93 approved these changes Nov 6, 2026

View reviewed changes

lucamicheletti93 merged commit 5fec492 into AliceO2Group:master Nov 6, 2026
22 of 24 checks passed

Navigation Menu

Repository navigation

[PWGDQ] Remove reinterpret_cast and add extra protections in MCH tracking eff macro - #18379

[PWGDQ] Remove reinterpret_cast and add extra protections in MCH tracking eff macro#18379
lucamicheletti93 merged 4 commits into
AliceO2Group:masterfrom
atavirag:mch-macro-fix

atavirag commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

alibuild commented Oct 21, 2026 •

edited

Loading

Uh oh!

alibuild commented Oct 21, 2026

Uh oh!

axti98 commented Nov 5, 2026 •

edited

Loading

Uh oh!

atavirag commented Nov 6, 2026

Uh oh!

lucamicheletti93 commented Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

atavirag commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

alibuild commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Oct 21, 2026

Uh oh!

axti98 commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

atavirag commented Nov 6, 2026

Uh oh!

lucamicheletti93 commented Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

alibuild commented Oct 21, 2026 •

edited

Loading

axti98 commented Nov 5, 2026 •

edited

Loading