Repository navigation
[PWGHF] Fix the unit mismatch in QA histogram filling - #18577
Merged
Merged
Conversation
hero-seo
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera,
xinyepeng and
zhangbiao-phy
as code owners
November 4, 2026 04:52
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Contributor
Author
|
Dear reviewers, could you please approve it if the changes in this PR look good? |
fcatalan92
approved these changes
Nov 9, 2026
lubynets
reviewed
Nov 9, 2026
| registry.add("hInteractionsWithMaterial", "hInteractionsWithMaterial", {HistType::kTH1F, {{6, -0.5, 5.5}}}); | ||
| registry.add("hDebugRec", "hDebugRec", {HistType::kTH1F, {{4, -0.5, 3.5}}}); | ||
| registry.add("hy_pt_gen", "Generated MC", {HistType::kTH2F, {{20, -1.0, 1.0}, {200, 0, 20}}}); | ||
| registry.add("hYPtGen", "Generated MC", {HistType::kTH2F, {{20, -1.0, 1.0}, {200, 0, 20}}}); |
Contributor
There was a problem hiding this comment.
Hi @hero-seo here you add() the histogram under condition if (fillMcHistograms) but attempt to fill it in the line 1353 unconditionally, therefore the task crashes when fillMcHistograms == false. Please fix the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor bug related to a unit mismatch in the QA histograms.
In candidateCreatorXicToXiPiPi.cxx, the QA histograms for the impact parameter are defined in µm, but the values were filled in cm. This PR fixes the inconsistency by converting the values from cm to µm using a factor of 10000.f.
In addition, some histogram names have been changed from snake_case to camelCase for consistency.