Skip to content

[PWGCF] Add EvSel and QA histos in cascDiHadronCorr.cxx- #18580 - #18582

Merged
wenyaCern merged 1 commit into
AliceO2Group:masterfrom
fuchuncui:branch1
Nov 4, 2026
Merged

wenyaCern merged 1 commit into
AliceO2Group:masterfrom
fuchuncui:branch1

Conversation

@fuchuncui

@fuchuncui fuchuncui commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Add event selection for collisions with Xi or Omega
Add some QA plots
Add a new cfgCutChi2prTPCcls for cascades daughters only to separate the selection from ref ch particles

@github-actions github-actions Bot added the pwgcf label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@fuchuncui
fuchuncui marked this pull request as ready for review November 4, 2026 09:52
@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 39b94d5 at 2026-11-04 11:10:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 6 errors and 234 warnings.'
Found 6 errors and 234 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/b302337fba31423a0e5e5dff8912865221fe911c/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:204:199: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:815:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:827:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1095:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1194:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1301:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
++ [[ 234 -gt 0 ]]
++ cat /sw/BUILD/b302337fba31423a0e5e5dff8912865221fe911c/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:65:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:67:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:262:29: warning: use designated initializer list to initialize 'ValidParticle' [modernize-use-designated-initializers]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:320:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:322:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:325:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:327:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:330:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:332:56: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:335:54: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:337:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:372:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:474:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:507:11: warning: variable 'cent' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:556:116: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:558:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:560:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:562:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:564:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:566:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:582:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:584:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:586:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:588:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:590:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:592:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:595:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:597:66: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@wenyaCern
wenyaCern merged commit 591ffa8 into AliceO2Group:master Nov 4, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants