Skip to content

[PWGCF] Implement collision tagger in femto framework - #18607

Merged
ariedel-cern merged 3 commits into
AliceO2Group:masterfrom
ariedel-cern:master
Nov 5, 2026
Merged

ariedel-cern merged 3 commits into
AliceO2Group:masterfrom
ariedel-cern:master

Conversation

@ariedel-cern

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern
ariedel-cern merged commit 7b06eaf into AliceO2Group:master Nov 5, 2026
14 of 15 checks passed
@alibuild

alibuild commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4810f67 at 2026-11-05 19:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 13 errors and 97 warnings.'
Found 13 errors and 97 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/4e88f743ffee4d6c1b3170b332c4cdc57ccb6fac/O2Physics-code-check/errors.txt
PWGCF/Femto/Tasks/femtoPairD0D0.cxx:175:70: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairTrackCascade.cxx:224:70: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairTrackCharmHadron.cxx:213:70: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairTrackKink.cxx:232:73: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairTrackTrack.cxx:186:66: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairTrackTwoPhotonResonance.cxx:177:71: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairTrackTwoTrackResonance.cxx:200:71: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairTrackV0.cxx:224:74: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairV0TwoTrackResonance.cxx:323:77: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoPairV0V0.cxx:263:80: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoTripletTrackTrackCascade.cxx:238:70: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoTripletTrackTrackTrack.cxx:159:73: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Tasks/femtoTripletTrackTrackV0.cxx:181:73: error: no header providing "o2::analysis::femto::datatypes::CollisionTagType" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 97 -gt 0 ]]
++ cat /sw/BUILD/4e88f743ffee4d6c1b3170b332c4cdc57ccb6fac/O2Physics-code-check/warnings.txt
PWGCF/Femto/Core/collisionTagger.h:470:21: warning: use starts_with instead of rfind [modernize-use-starts-ends-with]
PWGCF/Femto/Core/collisionTagger.h:485:7: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGCF/Femto/Core/collisionTagger.h:515:7: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGCF/Femto/Core/collisionTagger.h:539:7: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGCF/Femto/Core/collisionTagger.h:609:7: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGCF/Femto/Core/collisionTagger.h:660:77: warning: forwarding reference parameter 'passes' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
PWGCF/Femto/Core/collisionTagger.h:676:123: warning: forwarding reference parameter 'passes' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
PWGCF/Femto/Core/collisionTagger.h:692:127: warning: forwarding reference parameter 'passes1' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
PWGCF/Femto/Core/collisionTagger.h:692:170: warning: forwarding reference parameter 'passes2' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
PWGCF/Femto/Core/collisionTagger.h:705:120: warning: forwarding reference parameter 'passes' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
PWGCF/Femto/Core/collisionTagger.h:717:126: warning: forwarding reference parameter 'passes' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
PWGCF/Femto/Core/collisionTagger.h:740:134: warning: forwarding reference parameter 'passes1' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
PWGCF/Femto/Core/collisionTagger.h:740:177: warning: forwarding reference parameter 'passes2' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
PWGCF/Femto/Core/collisionTagger.h:854:39: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Femto/Core/collisionTagger.h:863:39: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Femto/Core/collisionTagger.h:866:39: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Femto/Core/collisionTagger.h:873:39: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Femto/Core/collisionTagger.h:876:39: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Femto/Core/collisionTagger.h:880:39: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Femto/Core/collisionTagger.h:883:39: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Femto/Core/collisionTagger.h:886:39: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
[0 more errors; see full log]

Full log here.

@ariedel-cern

Copy link
Copy Markdown
Collaborator Author

Fixing code-check errors/warnings in #18613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants