[PWGJE] jetShape: add 2D (TPC x TOF) PID maps for template fits by ynishida-style · Pull Request #18616 · AliceO2Group/O2Physics

ynishida-style · 2026-11-06T09:24:43Z

・Update the histograms to use a two-dimensional fit of the TPC and TOF nσ values for PID.
・Add templates for calculating TOF mismatches.

github-actions · 2026-11-06T09:25:02Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild · 2026-11-06T10:49:47Z

Error while checking build/O2Physics/staging for 00ebe0d at 2026-11-06 11:49:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1131:66: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1171:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1223:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1278:68: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1446:78: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1131:66: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1171:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1223:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1278:68: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1131:66: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1171:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1223:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1278:68: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-11-06T13:05:19Z

Error while checking build/O2Physics/code-check for 00ebe0d at 2026-11-06 14:05:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 1 warnings.'
Found 5 errors and 1 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/130ee79e641a224496676a59908e94e8addb0118/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetShape.cxx:1131:66: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGJE/Tasks/jetShape.cxx:1171:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGJE/Tasks/jetShape.cxx:1223:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGJE/Tasks/jetShape.cxx:1278:68: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGJE/Tasks/jetShape.cxx:1446:78: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/130ee79e641a224496676a59908e94e8addb0118/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetShape.cxx:695:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-11-06T13:49:33Z

Error while checking build/O2Physics/o2 for 00ebe0d at 2026-11-06 14:49:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1131:66: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1171:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1223:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1278:68: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1446:78: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1131:66: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1171:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1223:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1278:68: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1131:66: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1171:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1223:72: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1278:68: error: arithmetic between enumeration type 'JetShapeTask::Pid2DRegion' and floating-point type 'float' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-11-07T08:56:28Z

Error while checking build/O2Physics/staging for 2b20d33 at 2026-11-07 09:56:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

alibuild · 2026-11-07T08:57:52Z

Error while checking build/O2Physics/code-check for 2b20d33 at 2026-11-07 09:57:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

alibuild · 2026-11-07T08:59:27Z

Error while checking build/O2Physics/o2 for 2b20d33 at 2026-11-07 09:59:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

[PWGJE] jetShape: add 2D (TPC x TOF) PID maps for template fits

00ebe0d

ynishida-style requested review from alibuild, fjonasALICE, jaimenorman, mhemmer-cern and nzardosh as code owners November 6, 2026 09:24

github-actions Bot added the pwgje label Nov 6, 2026

nzardosh previously approved these changes Nov 6, 2026

View reviewed changes

nzardosh enabled auto-merge (squash) November 6, 2026 10:12

Fix build errors

2b20d33

auto-merge was automatically disabled November 7, 2026 08:54
Head branch was pushed to by a user without write access

ynishida-style dismissed nzardosh’s stale review via 2b20d33 November 7, 2026 08:54

Navigation Menu

Repository navigation

[PWGJE] jetShape: add 2D (TPC x TOF) PID maps for template fits - #18616

[PWGJE] jetShape: add 2D (TPC x TOF) PID maps for template fits#18616
ynishida-style wants to merge 2 commits into
AliceO2Group:masterfrom
ynishida-style:pwgje-jetshape-pid2d

ynishida-style commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026

Uh oh!

alibuild commented Nov 6, 2026

Uh oh!

alibuild commented Nov 6, 2026

Uh oh!

alibuild commented Nov 6, 2026

Uh oh!

alibuild commented Nov 7, 2026

Uh oh!

alibuild commented Nov 7, 2026

Uh oh!

alibuild commented Nov 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

ynishida-style commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026

Uh oh!

alibuild commented Nov 6, 2026

Uh oh!

alibuild commented Nov 6, 2026

Uh oh!

alibuild commented Nov 6, 2026

Uh oh!

alibuild commented Nov 7, 2026

Uh oh!

alibuild commented Nov 7, 2026

Uh oh!

alibuild commented Nov 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants