Skip to content

[PWGHF] HF-h correl tasks: fix DCA selections on associated tracks - #18618

Merged
apalasciano merged 2 commits into
AliceO2Group:masterfrom
apalasciano:dcaFix
Nov 6, 2026
Merged

apalasciano merged 2 commits into
AliceO2Group:masterfrom
apalasciano:dcaFix

Conversation

@apalasciano

Copy link
Copy Markdown
Collaborator

@scattaru @zz951
DCA ambiguity in the selection of associated particles.
If, in the correlator, a looser selection is applied than in the task, larger negative DCA tracks are taken into account.
If, instead, the same DCA cut is used, the filter in the correlator provides the correct selection.

This removes ambiguities.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 5c31fbd at 2026-11-06 12:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationLcHadrons.cxx:493:17: error: unused variable 'trackTpcCrossedRows' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 5c31fbd at 2026-11-06 12:17:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationLcHadrons.cxx:493:17: error: unused variable 'trackTpcCrossedRows' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5c31fbd at 2026-11-06 14:56:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 30 warnings.'
Found 2 errors and 30 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/c689bd538324ba1b7b536b4a9ca22938d2af8a3c/O2Physics-code-check/errors.txt
PWGHF/HFC/Tasks/taskCorrelationLcHadrons.cxx:493:17: error: Value stored to 'trackTpcCrossedRows' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationLcHadrons.cxx:493:17: error: unused variable 'trackTpcCrossedRows' [clang-diagnostic-unused-variable,-warnings-as-errors]
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/c689bd538324ba1b7b536b4a9ca22938d2af8a3c/O2Physics-code-check/warnings.txt
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:82:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:83:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:83:76: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:84:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:85:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:86:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:87:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:88:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:89:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:90:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:90:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:91:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:91:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:92:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:92:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:93:55: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:93:81: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:94:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:94:83: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:95:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:95:83: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:84:36: warning: variable 'channelsResonant' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:411:101: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:414:111: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:433:149: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:436:116: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:436:263: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:438:128: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:441:116: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:441:242: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
++ [[ 2 -gt 0 ]]
++ exit 1
[0 more errors; see full log]

Full log here.

@apalasciano
apalasciano enabled auto-merge (squash) November 6, 2026 15:01

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @apalasciano.

@apalasciano
apalasciano merged commit c1c0c08 into AliceO2Group:master Nov 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants