Repository navigation
[PWGEM] Add new overlay mixed event - #18621
Merged
jokonig merged 6 commits intoNov 7, 2026
Merged
Conversation
github-actions
Bot
added
pwgem
datamodel
photon
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
Steffimro
marked this pull request as ready for review
November 6, 2026 12:58
Steffimro
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
jokonig,
mhemmer-cern and
reygers
as code owners
November 6, 2026 12:58
mhemmer-cern
reviewed
Nov 6, 2026
| kEvent_JJ = 3, | ||
| }; | ||
|
|
||
| Configurable<bool> storeVertex{"storeVertex", false, "write EMEventsXY and EMEventsCov (primary vertex x, y, covariance, chi2), joinable to PMEvents: needed by the co-reconstructed mixed event on derived data (photon-mixed-event-producer processDerived)"}; |
Collaborator
There was a problem hiding this comment.
Since a new feature of the frame work will let us actually disable writing of tables, I think it would be good to rename the config and rephrase the info that this is just about filling the table. Currently the table will be written anyways.
Collaborator
|
Error while checking build/O2Physics/code-check for f3950d4 at 2026-11-06 14:26: Full log here. |
added 2 commits
November 6, 2026 15:47
Collaborator
|
Error while checking build/O2Physics/code-check for 08136eb at 2026-11-06 17:22: Full log here. |
jokonig
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason behind this pull request: Close photon pairs at small q_inv are affected by reconstruction effects
that the standard mixed event cannot reproduce: legs of two nearby conversions can be paired the wrong way (swaps), one conversion can be split into two photons, and photons compete for the same legs in the deduplication. The new mixed event rebuilds the photons of two overlaid events with the same code as the same event, so these effects enter the same and the mixed event alike.
For this to be realized two new tasks have been introduced the photon-mixed-event-producer and photon-conversion-builder-mixed. The latter is just a second round of the photon-conversion-builder. It runs over processMixed and processMixedDerived (TODO: see how this might be achievable with linked derived data).
Adjustments in the builder (all new outputs are off by default, so nothing changed for the user if not activated.)
Since recent runs over the full data set also caused some CPU issues the run 1 with finder was optimized realized and tested that the output did not change (sorting of tracks in a time window + order of cuts was optimized so heavy propagation is done mostly on tracks which do not cause issues).
The builder stores now - storeLegCov: V0LegsCov, the leg parameters and covariance given to the
V0 fit (input of the mixer). storeFreeLegs: PCMFreeLegs, tracks that pass the leg cuts and are the leg of no stored photon. storeFreeLegIds: PCMFreeLegIds, the same free legs as AO2D track indices only, for linked derived data (track index stored as the difference to the previous row TODO: need to finalize the mixing task that it can run over the linked derived data).
Tables and event tasks