Repository navigation
[Common] factorize the occupancy calculation into OccupancyCalculator - #18623
Merged
Merged
Conversation
added OccupancyCalculator class for occupancy calculations within EventSelectionModule
altsybee
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
November 6, 2026 15:05
|
O2 linter results: ❌ 0 errors, |
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for 524cc34 at 2026-11-06 17:58: Full log here. |
dsekihat
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventSelectionModule: factorize the occupancy calculation into OccupancyCalculator
EventSelectionModule::processRun3into a new classOccupancyCalculator:OccupancyCalculator::Source(per-collision inputs) andOccupancyCalculator::Result(occupancy estimators and flags);
calculate(refGlobalBC, refVz, ...)computes the occupancy wrt a reference BC, so the samecode can later provide occupancy at the BC level;
calculateForSource(i, ...)is thecollision-level call used in
processRun3.processRun3fills the per-collision inputs and takes the occupancy values and flags from thecalculator; the per-collision temporary vectors (and vectors of vectors) are removed.