Skip to content

[PWGLF] updated primary and secondary selections, fix multiplicity determination, include histos for decay mothers - #18625

Open
calmonbehling wants to merge 2 commits into
AliceO2Group:masterfrom
calmonbehling:master
Open

calmonbehling wants to merge 2 commits into
AliceO2Group:masterfrom
calmonbehling:master

Conversation

@calmonbehling

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwglf label Nov 6, 2026
@github-actions github-actions Bot changed the title updated primary and secondary selections, fix multiplicity determination, include histos for decay mothers [PWGLF] updated primary and secondary selections, fix multiplicity determination, include histos for decay mothers Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 1 disabled

@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for d201ded at 2026-11-07 09:34:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

@alibuild

alibuild commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d201ded at 2026-11-08 00:53:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 7 errors and 6 warnings.'
Found 7 errors and 6 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/cf3a90720ac19fa64322274d4900c9a857d1b28a/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/pccQa.cxx:33:1: error: included header TPDGCode.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/pccQa.cxx:45:16: error: no header providing "std::abs" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/pccQa.cxx:99:20: error: no header providing "std::shared_ptr" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/pccQa.cxx:99:31: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/pccQa.cxx:101:31: error: no header providing "TProfile" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/pccQa.cxx:183:31: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/pccQa.cxx:193:14: error: no header providing "fmt::format" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/cf3a90720ac19fa64322274d4900c9a857d1b28a/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Nuspex/particleCompositionCorrection.cxx:47:8: warning: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init]
PWGLF/TableProducer/Nuspex/particleCompositionCorrection.cxx:218:22: warning: implicit conversion 'float' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Nuspex/particleCompositionCorrection.cxx:218:22: warning: narrowing conversion from 'float' to 'bool' [bugprone-narrowing-conversions]
PWGLF/TableProducer/Nuspex/particleCompositionCorrection.cxx:286:23: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Nuspex/pccQa.cxx:95:8: warning: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/Nuspex/pccQa.cxx:305:29: warning: unused local variable 'motherName' of type 'const std::string' (aka 'const basic_string<char>') [bugprone-unused-local-non-trivial-variable]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d201ded at 2026-11-07 09:35:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants