Skip to content

[PWGHF] taskCorrelationsEfficiencies: apply selections on generated tracks and collisions - #18633

Merged
stefanopolitano merged 30 commits into
AliceO2Group:masterfrom
Marcellocosti:fix_correl
Nov 8, 2026
Merged

stefanopolitano merged 30 commits into
AliceO2Group:masterfrom
Marcellocosti:fix_correl

Conversation

@Marcellocosti

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwghf PWG-HF label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#18633
@Marcellocosti
Marcellocosti marked this pull request as ready for review November 6, 2026 20:17
@alibuild

alibuild commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 88182b7 at 2026-11-06 21:59:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 27 errors and 21 warnings.'
Found 27 errors and 21 warnings.
++ [[ 27 -gt 0 ]]
++ cat /sw/BUILD/ef062cbd4a28086cab10af73bb63e4b4a4a27af7/O2Physics-code-check/errors.txt
PWGHF/HFC/TableProducer/derivedDataCreatorCorrelationsReduced.cxx:35:1: error: included header PhysicsConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:17:1: error: included header HfHelper.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:33:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:34:1: error: included header PhysicsConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:178:56: error: no header providing "o2::framework::RunningWorkflowInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:179:16: error: no header providing "o2::framework::DeviceSpec" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:254:70: error: no header providing "o2::hf_decay::hf_cand_2prong::DecayChannelMain" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:256:70: error: no header providing "o2::hf_decay::hf_cand_3prong::DecayChannelMain" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:267:68: error: no header providing "o2::hf_decay::hf_cand_3prong::DecayChannelResonant" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:357:12: error: no header providing "kPiPlus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:359:12: error: no header providing "kKPlus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:361:12: error: no header providing "kProton" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:363:12: error: no header providing "kElectron" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:365:12: error: no header providing "kMuonMinus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:419:22: error: no header providing "THnSparse" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:20:1: error: included header DecayChannels.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:24:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:27:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:28:1: error: included header PhysicsConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:32:1: error: included header AnalysisTask.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:33:1: error: included header Configurable.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:35:1: error: included header HistogramSpec.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:36:1: error: included header InitContext.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:40:1: error: included header TPDGCode.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:43:1: error: included header cstddef is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:44:1: error: included header cstdint is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Utils/utilsFlow.h:227:14: error: no header providing "std::abort" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 21 -gt 0 ]]
++ cat /sw/BUILD/ef062cbd4a28086cab10af73bb63e4b4a4a27af7/O2Physics-code-check/warnings.txt
PWGHF/HFC/TableProducer/derivedDataCreatorCorrelationsReduced.cxx:381:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGHF/HFC/TableProducer/derivedDataCreatorCorrelationsReduced.cxx:399:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGHF/HFC/TableProducer/derivedDataCreatorCorrelationsReduced.cxx:420:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGHF/HFC/TableProducer/derivedDataCreatorCorrelationsReduced.cxx:441:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGHF/HFC/TableProducer/derivedDataCreatorCorrelationsReduced.cxx:463:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGHF/HFC/TableProducer/derivedDataCreatorCorrelationsReduced.cxx:484:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGHF/HFC/TableProducer/derivedDataCreatorCorrelationsReduced.cxx:506:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
[0 more errors; see full log]

Full log here.

Please consider the following formatting changes to AliceO2Group#18633
@alibuild

alibuild commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9f5d983 at 2026-11-07 12:22:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 12b64c2 at 2026-11-07 15:45:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

Please consider the following formatting changes to AliceO2Group#18633
@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 12b64c2 at 2026-11-07 15:46:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for f83f214 at 2026-11-07 15:46:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

@alibuild

alibuild commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f83f214 at 2026-11-08 04:15:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/8787da46026f03c2060c83db2520e4d95d26ceb5/O2Physics-code-check/errors.txt
PWGHF/HFC/Tasks/taskCorrelationsEfficiencies.cxx:18:1: error: included header HfHelper.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for f83f214 at 2026-11-07 15:48:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

@stefanopolitano
stefanopolitano merged commit 88eb493 into AliceO2Group:master Nov 8, 2026
13 of 14 checks passed
@Marcellocosti
Marcellocosti deleted the fix_correl branch November 8, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants