Skip to content

[Common] Fix unused variables, parameters, values #18638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsekihat merged 1 commit into from
Nov 9, 2026
+14 −13
Merged

[Common] Fix unused variables, parameters, values #18638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Common/Core/macros/testCollisionTypeHelper.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ void testCollisionTypeHelper(int runNumber = 544124)
o2::parameters::GRPLHCIFData* grpo = ccdb.getSpecificForRun<o2::parameters::GRPLHCIFData>("GLO/Config/GRPLHCIF",
runNumber);
grpo->print();
int collsys = o2::common::core::CollisionSystemType::getCollisionTypeFromGrp(grpo);
[[maybe_unused]] int collsys = o2::common::core::CollisionSystemType::getCollisionTypeFromGrp(grpo);
}
2 changes: 1 addition & 1 deletion Common/TableProducer/PID/pidTOFBase.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ struct tofEventTime {
// Reset the event time
eventTime = 0.f;
sumOfWeights = 0.f;
weight = 0.f;
// weight = 0.f; // FIXME: unused
// Remove the bias on TOF ev. time
if constexpr (removeTOFEvTimeBias) {
evTimeTOF.removeBias<TrksEvTime::iterator, filterForTOFEventTime>(trk, nGoodTracksForTOF, t0TOF[0], t0TOF[1], 2);
Expand Down
2 changes: 1 addition & 1 deletion Common/TableProducer/PID/pidTOFMerge.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ struct tofEventTime {
// Reset the event time
eventTime = 0.f;
sumOfWeights = 0.f;
weight = 0.f;
// weight = 0.f; // FIXME: unused
// Remove the bias on TOF ev. time
if constexpr (kRemoveTOFEvTimeBias) {
evTimeMakerTOF.removeBias<Run3TrksWtof::iterator, filterForTOFEventTime>(trk, nGoodTracksForTOF, t0TOF[0], t0TOF[1], 2);
Expand Down
12 changes: 6 additions & 6 deletions Common/TableProducer/caloClusterProducer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,9 +1116,9 @@ struct CaloClusterProducer {
if (cpvdist != 99.) { // was evaluated
cpvdist = std::sqrt(cpvdist); // was squared
}
if (trackdist != 99.) { // was evaluated
trackdist = std::sqrt(trackdist); // was squared
}
// if (trackdist != 99.) { // was evaluated
// trackdist = std::sqrt(trackdist); // was squared // FIXME: unused
// }

float lambdaShort = 0., lambdaLong = 0.;
clu.getElipsAxis(lambdaShort, lambdaLong);
Expand Down Expand Up @@ -1544,9 +1544,9 @@ struct CaloClusterProducer {
if (cpvdist != 99.) { // was evaluated
cpvdist = std::sqrt(cpvdist); // was squared
}
if (trackdist != 99.) { // was evaluated
trackdist = std::sqrt(trackdist); // was squared
}
// if (trackdist != 99.) { // was evaluated
// trackdist = std::sqrt(trackdist); // was squared // FIXME: unused
// }

float lambdaShort = 0., lambdaLong = 0.;
clu.getElipsAxis(lambdaShort, lambdaLong);
Expand Down
2 changes: 1 addition & 1 deletion Common/TableProducer/match-mft-ft0.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ struct matchmftft0 {

auto ft0s = bc.ft0s();
i = 0; // reinitialise
D = 0.0;
// D = 0.0; // FIXME: unused
minD = 999.9;
for (auto const& ft0 : ft0s) {
// printf("---------ft0.bcId %d\n", ft0.bcId());
Expand Down
2 changes: 1 addition & 1 deletion Common/Tools/Multiplicity/macros/runCalibration.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ void runCalibration(const TString& lInputFileName = "results/AR_544122_glauberNB

TH1F* hData = dynamic_cast<TH1F*>(file->Get("hV0MUltraFine"));
TH1F* hGlauberParameters = dynamic_cast<TH1F*>(file->Get("hGlauberParameters"));
TH1F* hGlauberFitRange = dynamic_cast<TH1F*>(file->Get("hGlauberFitRange"));
[[maybe_unused]] TH1F* hGlauberFitRange = dynamic_cast<TH1F*>(file->Get("hGlauberFitRange"));
hData->SetName("hData");
TH1F* hStitched = dynamic_cast<TH1F*>(hData->Clone("hStitched"));
TH1F* hFit = dynamic_cast<TH1F*>(file->Get("hGlauber"));
Expand Down
4 changes: 2 additions & 2 deletions Common/Tools/Multiplicity/macros/runGlauberFit.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,8 +357,8 @@ int runGlauberFit(const TString& lInputFileName = "AnalysisResultsLHC24ar.root",
c1->cd(1);
TLatex* lat = new TLatex();
lat->SetNDC();
Float_t lPosText = 0.76;
Float_t lYShift = 0.25;
// Float_t lPosText = 0.76; // FIXME: unused
// Float_t lYShift = 0.25; // FIXME: unused
lat->SetTextSize(0.042);

// save the glauber parameters explicitly
Expand Down
1 change: 1 addition & 0 deletions Common/Tools/Multiplicity/macros/saveCorrelation.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ void saveCorrelation(const TString& filename = "gmc-PbPb-snn68.21-md0.40-nd-1.0-

// 2D correlation plot necessary for Glauber + NBD fitting
// The provided range should be enough for Pb-Pb
// NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores,clang-diagnostic-unused-variable)
TH2D* hNpNc = new TH2D("hNpNc", "", 500, -0.5, 499.5, 2500, -0.5, 2499.5);

// let's draw this on screen for inspection
Expand Down
Loading