Skip to content

[PWGLF,PWGMM] Fix unused variables, parameters, values #18646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkucera wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −17
Open

[PWGLF,PWGMM] Fix unused variables, parameters, values #18646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions PWGMM/Lumi/Tasks/lumiStability.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,11 +276,11 @@ struct LumiStabilityTask {
int executionCounter = 0;
int nbin = o2::constants::lhc::LHCMaxBunches;
uint32_t nOrbitsPerTF = 0; // 128 in 2022, 32 in 2023
if (is2022Data) {
nOrbitsPerTF = 128; // 128 in 2022, 32 in 2023
} else {
nOrbitsPerTF = 32; // 128 in 2022, 32 in 2023
}
// if (is2022Data) {
// nOrbitsPerTF = 128; // 128 in 2022, 32 in 2023 // FIXME: unused
// } else {
// nOrbitsPerTF = 32; // 128 in 2022, 32 in 2023 // FIXME: unused
// }
int runNumber = bcs.iteratorAt(0).runNumber();
if (runNumber != lastRunNumber && executionCounter < 1) {
tsSOR = 0;
Expand Down Expand Up @@ -497,8 +497,8 @@ struct LumiStabilityTask {
pastActivityFDDVertex |= (vertexPast);
}
}
deltaIndex = 0;
deltaBC = 0;
// deltaIndex = 0; // FIXME: unused
// deltaBC = 0; // FIXME: unused

if (pastActivityFDDVertex == false) {
histos.fill(HIST("FDD/hCounts"), 2);
Expand Down Expand Up @@ -645,8 +645,8 @@ struct LumiStabilityTask {
pastActivityFDDTriggerCCoincidenceC |= (triggerCPast & isCoinCPast);
}
}
deltaIndex = 0;
deltaBC = 0;
// deltaIndex = 0; // FIXME: unused
// deltaBC = 0; // FIXME: unused

if (pastActivityFDDVertexCoincidences == false) {
histos.fill(HIST("FDD/hCounts"), 4);
Expand Down Expand Up @@ -782,8 +782,8 @@ struct LumiStabilityTask {
pastActivityFT0TriggerC |= triggerCPast;
}
}
deltaIndex = 0;
deltaBC = 0;
// deltaIndex = 0; // FIXME: unused
// deltaBC = 0; // FIXME: unused

histos.fill(HIST("FT0/hCounts"), 1);
if (pastActivityFT0Vertex == false) {
Expand Down
2 changes: 1 addition & 1 deletion PWGMM/Lumi/macros/merger.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ void merger()
TFile* fout = new TFile("mergedOutput.root", "recreate");
TTree* tin = new TTree("EventInfo_merged", "");

TList* list = fin->GetListOfKeys();
// TList* list = fin->GetListOfKeys(); // FIXME: unused
TIter next(fin->GetListOfKeys());

ULong64_t fTimeStamp;
Expand Down
3 changes: 2 additions & 1 deletion PWGMM/Lumi/macros/non_fac.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ double tmax;

int Countig;

void chi2(Int_t& npar, Double_t* gin, Double_t& f, Double_t* par, Int_t flag)
void chi2(Int_t& /*npar*/, Double_t* /*gin*/, Double_t& f, Double_t* par, Int_t /*flag*/)
{
TMatrixD sigma(2, 2);
double results = 0.;
Expand Down Expand Up @@ -241,4 +241,5 @@ void non_fac()
for (int i = 0; i < 10; i++) {
hParam[i]->Write();
}
fout->Close();
}
4 changes: 2 additions & 2 deletions PWGMM/Mult/TableProducer/ambiguousTrackPropagation.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ struct AmbiguousTrackPropagation {
o2::track::TrackParCovFwd bestTrackPar;

for (auto const& atrack : atracks) {
dcaInfo = 999; // DCAxy
// dcaInfo = 999; // DCAxy // FIXME: unused
bestDCA = 999;

auto track = atrack.mfttrack();
Expand Down Expand Up @@ -375,7 +375,7 @@ struct AmbiguousTrackPropagation {
o2::track::TrackParCovFwd bestTrackPar;

for (auto const& track : tracks) {
dcaInfo = 999; // DCAxy
// dcaInfo = 999; // DCAxy // FIXME: unused
bestDCA = 999;

auto bestCol = track.has_collision() ? track.collisionId() : -1;
Expand Down
2 changes: 1 addition & 1 deletion PWGMM/Mult/Tasks/dndeta-hi.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ struct MultiplicityCounter {
auto pTrack = v0.template posTrack_as<DaughterTracks>();
auto nTrack = v0.template negTrack_as<DaughterTracks>();

if (0 && v0.v0radius() > v0radius &&
if (0 && v0.v0radius() > v0radius && // FIXME: always false
v0.v0cosPA() > v0cospa &&
abs(pTrack.eta()) < etadau &&
abs(nTrack.eta()) < etadau) {
Expand Down
2 changes: 1 addition & 1 deletion PWGMM/Mult/Tasks/vertexing-fwd.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ struct vertexingfwd {

for (auto& atrack : atracks) {

dcaXY = 999; // DCAxy
// dcaXY = 999; // DCAxy // FIXME: unused
bestDCA = 999;

auto track = atrack.mfttrack_as<MFTTracksLabeled>();
Expand Down
Loading