Skip to content

[PWGJE] Add ITS PID veto and pO rapidity QA to nuclei-in-jets analysis - #18649

Open
arvindkhuntia wants to merge 7 commits into
AliceO2Group:masterfrom
arvindkhuntia:master
Open

arvindkhuntia wants to merge 7 commits into
AliceO2Group:masterfrom
arvindkhuntia:master

Conversation

@arvindkhuntia

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 54 warnings, 🔕 0 disabled

@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for efe872c at 2026-11-08 00:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 213 warnings.'
Found 3 errors and 213 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/d35b4e4d9188ef2adf4bd15b2a13ce79490d676d/O2Physics-code-check/errors.txt
PWGJE/Tasks/nucleiInJets.cxx:94:12: error: no header providing "PDG_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/nucleiInJets.cxx:371:54: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGJE/Tasks/nucleiInJets.cxx:2126:66: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 213 -gt 0 ]]
++ cat /sw/BUILD/d35b4e4d9188ef2adf4bd15b2a13ce79490d676d/O2Physics-code-check/warnings.txt
PWGJE/Tasks/nucleiInJets.cxx:64:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Tasks/nucleiInJets.cxx:70:8: warning: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init]
PWGJE/Tasks/nucleiInJets.cxx:306:9: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGJE/Tasks/nucleiInJets.cxx:981:12: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/nucleiInJets.cxx:988:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:991:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:995:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:998:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1000:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1002:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1004:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1006:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1008:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1010:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1018:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1020:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1022:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1032:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1033:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Tasks/nucleiInJets.cxx:1034:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Tasks/nucleiInJets.cxx:1034:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1054:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1056:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1064:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1066:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1072:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1074:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1089:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1098:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1152:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1157:35: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants