Repository navigation
Add tested Mali/Bifrost gralloc3 support to minicap - #3
Merged
Merged
Conversation
Add descriptor-aware allocator@3.0 requests and validated linear RGBA dma-buf readback for the tested device. Fall back from an unavailable API 29 Qualcomm allocator and document the supported minicap capture modes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Test Plan: - go test ./gralloc -count=1 (pass) - go vet ./gralloc (pass) - Disabled fallback and partial cleanup separately; focused tests failed as expected. - go test -race ./gralloc -count=1: unavailable, ThreadSanitizer unsupported VMA range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All changes in this update were generated by GitHub Copilot. Since I lack the relevant Android low-level knowledge, I'm unable to review the code itself. However, I manually tested all use cases and parameter combinations in the minicap example's README.md, and they all worked successfully on my test device.
If there are any issues with the code, such as it not conforming to the project's conventions, feel free to close the PR directly.
Below is a summary generated by GitHub Copilot.
Summary
Device and architecture
ro.board.platform=rk3588, Android 10 (API 29).GOOS=linux GOARCH=arm64 CGO_ENABLED=0).Validation
go vet, formatting checks, andgit diff --checkpassed.