Repository navigation
fix(ci): don't block Release Please PRs on Cursor Bugbot - #60
teallarson wants to merge 1 commit into
Conversation
check timed out on #59 because Cursor Bugbot never started on its head commit. Skip the Bugbot wait on Release Please PRs while every commit on them is a GitHub-verified commit by arcade-plugin-bot[bot]; any other pushed commit restores the requirement. Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if [ "${PR_AUTHOR}" = "${RELEASE_BOT}" ] && [ "${HEAD_REPO}" = "${repo}" ] && [[ "${HEAD_REF}" == release-please--* ]]; then | ||
| other_commits="$( | ||
| gh api "repos/${repo}/pulls/${PR_NUMBER}/commits" --paginate | | ||
| jq -s --arg bot "${RELEASE_BOT}" '[.[][] | select(.author.login != $bot or .commit.verification.verified != true)] | length' |
There was a problem hiding this comment.
Missing permission fails release skip
High Severity
The skip path lists PR commits with GH_TOKEN, but the check job only grants checks: read. Job-level permissions replace the workflow grants and leave pull-requests as none, so gh api can 403 and set -euo pipefail fails the step before Bugbot is skipped or polled. Release Please PRs stay blocked, and check can fail even when Bugbot later succeeds.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ffb69a9. Configure here.
|
@BugBot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ffb69a9. Configure here.
What/why
What failed:
checkon the 0.9.2 release PR (#59) ran for 15 minutes printing "Waiting for Cursor Bugbot check to appear..." and then failed with "Timed out waiting for Cursor Bugbot" (job log). Every verify job passed, and the release contents are correct: all version-carrying files are at 0.9.2.Root cause: On every non-draft PR,
checkrequires a Cursor Bugbot check run on the head commit. On45fc922, Cursor's check suite stayedqueuedand Bugbot never created a check run. Bugbot had run on every earlier release-branch commit, so this was a miss on Cursor's side. That miss is enough to block a release PR made entirely of generated version bumps.Fix: Skip the Bugbot wait on Release Please PRs. The skip applies only when the PR is authored by
arcade-plugin-bot[bot], comes from arelease-please--*branch in this repo, and every commit on it is a GitHub-verified commit by that bot. If anyone else pushes a commit to the release branch, the Bugbot requirement comes back. Every other PR is unchanged.Codebase changes
.github/workflows/check.yml: adds the release-PR exemption ahead of the Bugbot polling loop.README.md: one sentence documenting the exemption.Additional notes
The commit type is
fix(ci)rather thancion purpose. Release Please only rewrites an open release PR when its release notes change, so this adds a changelog line, regenerates #59, and gives it a freshcheckrun that uses this workflow.Note
Low Risk
CI-only change with a narrow exemption; normal PRs still require Bugbot, and manual commits on release branches re-enable it.
Reviewed by Cursor Bugbot for commit ffb69a9. Bugbot is set up for automated code reviews on this repo. Configure here.