Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Related to #1453. That PR addresses transform composition.
What does this implement/fix?
The convergence residual subtracted input columns pairwise before matching them. Reordering one scan changed the residual, and unequal scan sizes could raise a broadcasting error. Reuse the nearest-neighbor distances for the stopping criterion.
Additional information
The regression checks a reordered identical scan and a shorter scan with known correspondences and nonzero residual. This changes association scoring independently of the transform accumulation in #1453. The regression failed on the original implementation and passed after the fix. Tested with Python 3.13.17 and the repository's pinned requirements. The modified module's tests and examples passed, Ruff passed, and the Sphinx HTML build succeeded.
CheckList