Repository navigation
Cherry-Pick: Fix NuGet audit failures blocking CI restore - #3887
Open
RubenCerna2079 wants to merge 1 commit into
Open
RubenCerna2079 wants to merge 1 commit into
RubenCerna2079 wants to merge 1 commit into
Conversation
## Why make this change? - Closes #3871 - New NuGet advisories for System.Security.Cryptography.Pkcs, MessagePack and Microsoft.OpenApi.Readers make the implicit restore in the Unit Tests pipeline's "Check formatting" step fail with 22 audit errors, blocking every PR to `main`. - Related: draft #3867 (overlapping version bumps). ## What is this change? - `Directory.Packages.props`: pin `System.Security.Cryptography.Pkcs` 9.0.21, bump `MessagePack` 2.5.301 -> 2.5.307, and bump `Microsoft.OpenApi` and `Microsoft.OpenApi.Readers` 1.6.14 -> 1.6.31 together. - Pkcs is only a transitive dependency, and central package management does not pin transitive versions without a reference. It is referenced from `Config` and `Core`, where `Microsoft.Data.SqlClient` enters the graph (`Core` also so the packed library declares it), and from `Aspire.AppHost`, whose restore graph does not include its project references. - No audit warnings are suppressed. ## How was this tested? - [ ] Integration Tests - [x] Unit Tests Locally with the CI SDK (10.0.402) and real NuGet vulnerability data: replaying CI's restore and `dotnet format --verify-no-changes` reproduces the 22 errors on `main` and passes on this branch (0 audit errors, 0 of 791 files changed). Full solution Release and Debug builds, including Aspire.AppHost, have 0 warnings; the Release pack succeeds; the CI unit test filter passes (Service.Tests 3254/3254, Cli.Tests 629 passed, 3 ignored in source). ## Sample Request(s) - N/A (package versions only).
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the dependency updates targeting NuGet vulnerability audit failures.
No open issues 🎉
What changed in this PR
Cherry-picks #3870 to address NuGet vulnerability audit failures blocking CI restore, without suppressing audit warnings.
Changes:
- Updates MessagePack to 2.5.307 and both OpenAPI packages to 1.6.31.
- Pins System.Security.Cryptography.Pkcs to 9.0.21 and adds explicit references so the patched dependency applies to Config, Core packaging, and Aspire.AppHost.
| File | Description |
|---|---|
src/Directory.Packages.props |
Sets patched package versions and documents the relevant advisories. |
src/Core/Azure.DataApiBuilder.Core.csproj |
Adds a Pkcs reference to preserve the patched dependency in the packed library. |
src/Config/Azure.DataApiBuilder.Config.csproj |
Adds a Pkcs reference to override SqlClient’s transitive dependency. |
src/Aspire.AppHost/Aspire.AppHost.csproj |
Adds a Pkcs reference for Aspire’s separate dependency graph. |
Review effort: Balanced
Souvik Ghosh (souvikghosh04)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
Cherry-picked PR:
How was this tested?
This is a cherry-pick it was already tested when it was first merged.
Sample Request(s)
N/A