Skip to content

chore: Debug-Release 앱 아이콘 분리 - #653

Merged
hgjwilly merged 1 commit into
developfrom
chore/appIcon
Nov 3, 2026
Merged

hgjwilly merged 1 commit into
developfrom
chore/appIcon

Conversation

@hgjwilly

@hgjwilly hgjwilly commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

#️⃣연관된 이슈

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

Debug-Release 앱 아이콘을 분리했습니다.

xcconfig에 ASSETCATALOG_COMPILER_APPICON_NAME를 추가하는 방식으로 작업했습니다.

actions secret DEBUG_XCCONFIG을 수정했습니다. (빌드엔 영향 없으나 일치시키기 위함)

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

Summary by CodeRabbit

  • New Features
    • Debug and release builds now use separate app icons, making the build type easier to distinguish.
    • The debug icon includes a visible “STAGE” label and is available in supported watchOS circle and square formats.

@hgjwilly hgjwilly self-assigned this Nov 3, 2026
@hgjwilly hgjwilly added the CHORE 그 외 수정 내용 label Nov 3, 2026
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The Xcode project now includes separate Debug and Release app icon assets. The Debug icon configuration defines artwork layers, visual effects, and platform shape settings.

Changes: App icon configuration

Layer / File(s) Summary
Debug icon asset
Koin/Resources/AppIcon-Debug.icon/icon.json
The Debug icon configuration adds a gray fill, a STAGE layer, five artwork layers, a group position, shadow and translucency settings, and watchOS circle and shared square configurations.
Project icon references
koin.xcodeproj/project.pbxproj
The project references the separate Debug and Release icon assets in its Resources group and build phase. It removes the explicit ASSETCATALOG_COMPILER_APPICON_NAME setting from the app’s Debug and Release configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related issues

  • Issue 652 requests separate Debug and Release icon assets and describes project updates that overlap with this change. The issue remains open; this change does not establish its status.

Suggested reviewers: oeunji

Merge Risk: Minimal · up to 8a6b2

This PR separates the Debug and Release app icons, and the project file references both icon assets correctly. Icon selection depends on local or CI-provided xcconfig files that are not in the repository. The author should confirm that the Release configuration sets the icon name to AppIcon-Release before cutting a release build; nothing in the versioned changes blocks merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: separating the Debug and Release app icons.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a63c64b7-6e3f-484e-bcf8-77b17d01e0a8
Commits

Reviewing files that changed from the base of the PR and between 096ddbd and 8a6b24f.

Files ignored due to path filters: 11
  • Koin/Resources/AppIcon-Debug.icon/Assets/Exclude 2.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Debug.icon/Assets/Eye Left — White Fill 2.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Debug.icon/Assets/Eye Right — White Fill 2.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Debug.icon/Assets/Union.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Debug.icon/Assets/Vector-1 3.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Debug.icon/Assets/Vector-2 3.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Release.icon/Assets/Eye Left — White Fill 2.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Release.icon/Assets/Eye Right — White Fill 2.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Release.icon/Assets/Union.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Release.icon/Assets/Vector-1 3.svg is excluded by !**/*.svg
  • Koin/Resources/AppIcon-Release.icon/Assets/Vector-2 3.svg is excluded by !**/*.svg
Files selected for processing: 3
  • Koin/Resources/AppIcon-Debug.icon/icon.json
  • Koin/Resources/AppIcon-Release.icon/icon.json
  • koin.xcodeproj/project.pbxproj

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@hgjwilly
hgjwilly merged commit f928670 into develop Nov 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHORE 그 외 수정 내용

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant