Skip to content
This repository was archived by the owner on Nov 9, 2026. It is now read-only.

Address sanitizer/ndk28c - #118

Merged
CedricGuillemet merged 39 commits into
BabylonJS:mainfrom
CedricGuillemet:ASAN
Nov 13, 2025
Merged

CedricGuillemet merged 39 commits into
BabylonJS:mainfrom
CedricGuillemet:ASAN

Conversation

@CedricGuillemet

@CedricGuillemet CedricGuillemet commented Oct 29, 2025 •

Copy link
Copy Markdown
Collaborator
  • up Android to ndk28c
  • add sanitizer builds to macOS and Linux
  • up AndroidExtensions commit id
  • fix uint16_t / char16_ casting
  • up macOS13 (soon deprecated) to macOS14
  • use clang for sanitizer on Linux ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80578 )
  • disable vptr check for ObjectWrap<T>::ObjectWrap (false positive)

@CedricGuillemet
CedricGuillemet marked this pull request as ready for review November 4, 2025 10:11
@CedricGuillemet CedricGuillemet changed the title Address sanitizer Address sanitizer/ndk28c Nov 4, 2025
Comment thread .github/jobs/linux.yml Resolved
Comment thread .github/jobs/macos.yml Resolved
Comment thread .github/jobs/linux.yml Resolved
Comment thread Tests/UnitTests/CMakeLists.txt Resolved

@matthargett matthargett left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions, thanks for peeling this out of the other PR!

Comment thread Tests/UnitTests/CMakeLists.txt Resolved
Comment thread .github/azure-pipelines.yml Resolved

@matthargett matthargett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor question, otherwise looks beautiful! (I'd approve, but I don't have that permission on this repo)

Comment thread CMakeLists.txt Resolved
Comment thread Polyfills/Blob/Source/Blob.cpp Resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants