Repository navigation
Open
Labels
apiPublic and supported Python API boundaries.Public and supported Python API boundaries.bugSomething isn't workingSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.Resolve, merge, or explicitly defer before the next full adversarial review.securitySecurity invariants, hardening, and security-sensitive boundaries.Security invariants, hardening, and security-sensitive boundaries.wallet/coreWallet integration and Bitcoin Core boundaries.Wallet integration and Bitcoin Core boundaries.
Description
core_descriptors(secret, ...) calls BitcoinCore.public_descriptors and returns the descriptors of whatever HD key the named Core wallet holds. It only type-checks secret, so a wallet holding a different seed returns that wallet's descriptors.
Nothing needs this path: ms32 wallet gives Core the root xprv (addhdkey) and Core builds the descriptors (createwalletdescriptor). Pre-1.0, remove it rather than authenticate it.
Fix in #130:
- remove
core_descriptors,WalletPublicDeriverand the unused descriptor-record path (codex32.__all__drops to 22 names); - remove the unused fresh Core Lightning generation exports; keep parsing, recovery and re-sharing of existing CL secrets;
- keep
master_xprvand Wallet: use Core for setup and remove test crypto deps #7's Core-native account-0 setup; nonzero accounts stay in wallet: Support nonzero accounts with Core-native setup #68.
Absorbs #63 (same removal) and #64. Found by Codex review of #94, after the four supplied audit reports; not attributable to those reviewers.
Metadata
Metadata
Assignees
Labels
apiPublic and supported Python API boundaries.Public and supported Python API boundaries.bugSomething isn't workingSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.Resolve, merge, or explicitly defer before the next full adversarial review.securitySecurity invariants, hardening, and security-sensitive boundaries.Security invariants, hardening, and security-sensitive boundaries.wallet/coreWallet integration and Bitcoin Core boundaries.Wallet integration and Bitcoin Core boundaries.
Activity
docs: Remove stale CL generation claims
docs: Record post-audit release gates
api: Remove unused public entry points
docs: Remove stale CL generation claims
api: Remove unused public entry points
docs: Remove stale CL generation claims
api: Remove unused public entry points
docs: Remove stale CL generation claims
api: Remove unused public entry points
docs: Remove stale CL generation claims
api: Remove unused public entry points
docs: Remove stale CL generation claims