Repository navigation
gui: Wait for a wallet choice and list new wallets as the CLI does - #219
Open
BenWestgate wants to merge 2 commits into
Open
BenWestgate wants to merge 2 commits into
BenWestgate wants to merge 2 commits into
Conversation
A list with one row drew a lone checkbox. Unticking it left nothing chosen, and Continue then raised StopIteration in _selected. Group every row under a hidden leader so even one row is a radio that cannot be unticked, start with nothing chosen, and keep Continue disabled until a choice is made. The wallet page asked Bitcoin Core again only on "Check again". Poll once a second instead, as the CLI waits for a new wallet, keeping the chosen wallet by name across a refresh. work.run now queues jobs behind one lock, so an import waits for a poll rather than failing as busy. Claude-Session: https://claude.ai/code/session_01N8jLK621Vh9wiv9ZntctSG
BenWestgate
marked this pull request as ready for review
November 9, 2026 18:42
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Can we move the polling to the API so we dont duplicate code between the CLI and GUI? |
BitcoinCore._eligible_wallets(names) looks once, without waiting, at which of the given wallets are eligible and returns their encryption and lock state. The CLI's menu and its wait for a new wallet use it with the names they already fetched, so the CLI asks Core exactly what it asked before and still offers only wallets that appeared while it waited. wallet_setup.eligible() is now an adapter over it. The GUI wallet page starts a poll only when the last one has reported, so a slow Core cannot pile polls up behind the work gate; work.busy() had no other use and is gone. Claude-Session: https://claude.ai/code/session_01N8jLK621Vh9wiv9ZntctSG
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
Stacked on #217 (the Bails pin line). One commit.
Bug
On "Which wallet should hold your keys?" with only the create row, the row drew as a lone checkbox. Unticking it left nothing chosen and Continue raised
StopIterationin_selected.Change
_radio_groupgroups every row under a hidden leader, so even one row is a radio that can't be unticked. Nothing is pre-chosen; the page's Continue stays disabled until a choice. Applies to the network, card-layout and wallet pages.work.runqueues jobs behind one lock instead of failing "busy", so an import waits for an in-flight poll.GUI lines: 2,045 (budget < 2,050; was 2,047).
Tests
python -m pytestunder Xvfb: 1,066 passed. Two new GTK tests fail on the parent commit.tools/gui_walkthrough.pyunder Xvfb: every check passed.Does not cherry-pick cleanly onto
gui-reviewability-v1; there, #66 covers the polling.Generated by Claude Code