Repository navigation
gui: Show wallet record values large and dark - #221
Open
BenWestgate wants to merge 1 commit into
Open
BenWestgate wants to merge 1 commit into
BenWestgate wants to merge 1 commit into
Conversation
The backup identifier and master fingerprint were small, dim row subtitles, hard to copy onto the wallet record. Rows that show values now use libadwaita's property style with the card-group text style, and the fingerprint is uppercase, as the CLI prints it. Claude-Session: https://claude.ai/code/session_01N8jLK8HGLaWJq2AJGmxPVe
BenWestgate
marked this pull request as ready for review
November 10, 2026 22:20
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
On "Write this on your wallet record", the backup identifier and master fingerprint were small grey row subtitles, which made them hard to copy.
Change
_rowsadds libadwaita'spropertystyle class, so the subtitle shows at full strength. The existing.card-grouprule now also matches.property .subtitle, which makes the values bold monospace in a tinted field like the share groups. This covers the record page, "No wallet record" and Finished.hex().upper()).parse_fingerprintalready accepts either case.Checked
wallet-record-display/.python -m pytest: 659 passed, 2 skipped.test_generic_hrp::test_cli_share_is_generic_and_ms32_share_is_scopedand the bip32-oracle modules can't run here because the cloud proxy blocks the pinnedbip32tarball, so CI covers them.< 2050. ruff and mypy are clean.Stacked on #217. Display only, no recovery logic is touched.
Generated by Claude Code