Repository navigation
gui: Let Enter move on from every text field - #222
Draft
BenWestgate wants to merge 1 commit into
Draft
BenWestgate wants to merge 1 commit into
BenWestgate wants to merge 1 commit into
Conversation
Enter in a field did nothing, so a card that "checks out" still needed a click on Continue. The CLI takes Enter as the answer to every prompt. _page now wires every text field it holds, once: Enter moves to the next shown field, and from the last presses the first page action that is switched on (the last action by default). Card entry falls back to "Suggest a repair", as the CLI offers a correction for a card that does not check out. Covers card entry, read-back, wallet record, new wallet, unlock, the YES gate and the custom layout numbers. Claude-Session: https://claude.ai/code/session_01N8jLK7DpgY81q3JWXK4Zvz
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
Bug. On "Restore my wallet ▸ Enter your cards", Enter did nothing even when every character checked out. No GUI text field handled Enter on this line (bails-v1-pin + #190/#191/#113/#217).
gui-reviewability-v1wires Enter per page on its two card fields only; this line never got it.Change. One helper in
_page, no per-page wiring. Enter in any text field moves to the next shown field, like the CLI's next prompt. From the last field it presses the first page action that is switched on: by default the primary (last) action. Card entry passes(Continue, Suggest a repair), the same way the CLI offers a correction for a card that doesn't check out. Actions that are switched off are never pressed.Covers card entry (restore, check, repair, replace, seed), read-back, wallet record (fingerprint, then date), new wallet (name, passphrase, repeat, then Create), unlock, the YES gate, and the custom layout spin rows.
Budget. The GUI goes from 2,047 to 2,069 lines, so
BUDGETgoes from 2050 to 2070. Ben to decide: keep the raise, or trim elsewhere.Checked.
tools/gui_walkthrough.pyon Xvfb now drives card entry, repair and read-back with Enter only, and checks field-to-field moves and that a switched-off action is never pressed: all 46 checks pass.python -m pytest: 658 passed, 2 skipped. The modules that need the bip32 oracle couldn't run because the proxy blocks its tarball, so CI covers them. ruff and mypy are clean.Stacked on #217. Touches share entry, so it needs Ben's security review before it's marked ready.
Generated by Claude Code