Repository navigation
gui: Grow the window so no page needs scrolling - #223
Merged
BenWestgate merged 1 commit intoNov 10, 2026
Merged
Conversation
Every page now asks the window to grow, never past the screen's height, whenever its content is taller than the space it has: on arrival, when a section opens, and when a message gets longer. A window the operator shrinks grows back to fit. The scroller stays as the last resort on a screen too short for the page. Name-and-value rows (wallet identity, wallet record, new card) are one line each, value on the right, so the finished page fits the default 880x620 window and reads straight down against the paper record. The GUI size budget rises by the 13 lines this takes. Claude-Session: https://claude.ai/code/session_01N8jLK9eptxLjUcNnMk1VGr
BenWestgate
marked this pull request as ready for review
November 10, 2026 22:32
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
Ben's VM screenshots showed the home window and the "Your wallet is back" page scrolling. The window there was about 470×450. At the default 880×620 size the home page fits, but the finished pages still did not.
Change (one shared fix in
_page, plus one in_rows):Checked (Xvfb, GTK 4.14, libadwaita 1.5). Every page was rendered with stub data: home, network, card count (both states), before-you-start, write, read-back, wallet picker (new/restore), unlock, new wallet, fingerprint (new/restore/mismatch), finished (created/restored/with warning), card entry, guess gate, intact/guessed, seed, letter, new card done, working.
python -m pytest: 1053 passed, 2 skipped.tools/gui_walkthrough.pypasses. ruff and mypy are clean.Stacked on #217 (the Bails pin line). The same change ports to
gui-reviewability-v1with two trivial conflicts (import line, budget).Generated by Claude Code