Repository navigation
fix(sdk-core): forward unstakingParams on custodial tx/initiate - #10103
Draft
OttoAllmendinger wants to merge 1 commit into
Draft
OttoAllmendinger wants to merge 1 commit into
OttoAllmendinger wants to merge 1 commit into
Conversation
Contributor
Contributor
|
|
sendMany on a custodial wallet dropped unstakingParams in three places, so a PoX-5 early exit (unstakingParams.pox5.branch = 'early-exit') was built as a late exit by the server: - BuildParams (buildParamKeys) did not list unstakingParams - initiateTransaction picked only TxSendBody keys from @bitgo/public-types - the TxSendBody codec is exact and strips unknown keys on encode Add unstakingParams to BuildParams and PrebuildTransactionOptions, and extend the initiate whitelist and codec locally until public-types declares it on TxSendBody. Refs: SI-2167 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
OttoAllmendinger
force-pushed
the
otto/SI-2167-custodial-early-exit-initiate
branch
from
October 30, 2026 09:26
4f9bea9 to
e0db596
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pairedWallet.sendMany({ ..., unstakingParams: { pox5: { branch: 'early-exit', principalPreimage } } })on a custodial PoX-5 paired wallet created a pending approval whose storedbuildParamshad nounstakingParams, so the server built a late-exit PSBT (locktime = unlock height, no preimage) instead of an early exit. The SDK dropped the field in three places before the request left the client:BuildParams(buildParamKeys) did not listunstakingParamsWallet.initiateTransactionpicked only the keys ofTxSendBodyfrom@bitgo/public-types, which does not declareunstakingParamsTxSendBodycodec is exact and strips unknown keys on encodeChange
unstakingParamstoBuildParamsandPrebuildTransactionOptions.TxInitiateBody,whitelistedInitiateParamsinwallet.ts) until@bitgo/public-typesdeclares it onTxSendBody.custodialInitiate.ts): the encoded initiate body keepsunstakingParams.Testing
modules/sdk-core:custodialInitiate.ts(2 passing).Refs: SI-2167
🤖 Generated with Claude Code