Repository navigation
fix(sdk-coin-starknet): remove dead Sepolia RPC dependency from unit test - #10104
Merged
shubham-damkondwar merged 1 commit intoOct 30, 2026
Merged
Conversation
…test The deploy-account wire format test called https://api.cartridge.gg/x/starknet/sepolia, which has been permanently discontinued (HTTP 410 Gone: 'starknet sepolia is discontinued and no longer served'). This broke unit tests for every BitGoJS PR that touches sdk-core or its dependents, because lerna runs the starknet test suite as a dependent module. Replace the live RPC call with local wire-format validation: parse the broadcast format, verify the JSON-RPC envelope serializes, and assert the required Starknet node fields (type, version, nonce, class_hash, contract_address_salt, constructor_calldata) exist. This verifies the same property — the wire format would reach node validation, not a param-parse error — without the external dependency. Refs: DEFI-961
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
|
shubham-damkondwar
approved these changes
Oct 30, 2026
bhavidhingra
approved these changes
Oct 30, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Starknet deploy account RPC wire formattest insdk-coin-starknetcallshttps://api.cartridge.gg/x/starknet/sepolia, which has been permanently discontinued (HTTP 410 Gone):This broke unit tests for every BitGoJS PR that touches sdk-core or its dependents, because lerna's
unit-test-changedruns the starknet suite as a dependent ofsdk-core. Evidence:Fix
Replace the live RPC call with local wire-format validation. The test previously verified that the broadcast format reaches the node's parameter validation layer (not a JSON parse error) by POSTing to the live RPC and checking the error message. The new version verifies the same property locally:
tx.toBroadcastFormat()as JSON — a parse failure would mean the node rejects before validationtype,version,nonce,class_hash,contract_address_salt,constructor_calldataThis tests the same property (the wire format is valid enough to reach node validation) without the external dependency.
Testing
Impact
Related