Repository navigation
added vcf header options - #74
alex-sandercock wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #74 +/- ##
===============================================
- Coverage 85.30% 84.60% -0.71%
===============================================
Files 22 22
Lines 3138 3390 +252
===============================================
+ Hits 2677 2868 +191
- Misses 461 522 +61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Existing positional callers are broken because the new parameters precede verbose in three functions, and the documentation incorrectly groups the AD field under Header.
4 open issues
6 files not reviewed
man/dosage2vcf.Rd: Generated fileman/filterVCF.Rd: Generated fileman/madc2vcf_all.Rd: Generated fileman/madc2vcf_multi.Rd: Generated fileman/madc2vcf_targets.Rd: Generated fileman/updog2vcf.Rd: Generated file
Review effort: Lite
| others_max_close_snps = 3, | ||
| vcf_header = NULL, | ||
| reference = NULL, | ||
| verbose = TRUE){ |
| markers_info = NULL, | ||
| ploidy = 2L, | ||
| vcf_header = NULL, | ||
| reference = NULL, | ||
| verbose = TRUE) { |
| collapse_matches_counts = FALSE, | ||
| vcf_header = NULL, | ||
| reference = NULL, | ||
| verbose = TRUE) { |
| #' - Header: the `##reference` and `##contig` lines come from `vcf_header` and/or | ||
| #' `reference`. A `##BIGrCommandLine` line with the function call is always | ||
| #' added. | ||
| #' * `AD` - `"ref,alt"` counts |
There was a problem hiding this comment.
🟡 Changes recommended
Existing positional-call compatibility is broken because newly added parameters precede established arguments in several public functions, causing prior calls to bind values incorrectly and fail validation.
6 open issues
Preserve output.file's positional argument slot · New Keep verbose before newly added parameters · New Append new options after verbose to preserve positional calls Preserve positional verbose arguments in madc2vcf_multi Append new options after verbose to preserve positional calls Fix Header and AD bullet ordering
6 files not reviewed
man/dosage2vcf.Rd: Generated fileman/filterVCF.Rd: Generated fileman/madc2vcf_all.Rd: Generated fileman/madc2vcf_multi.Rd: Generated fileman/madc2vcf_targets.Rd: Generated fileman/updog2vcf.Rd: Generated file
Review effort: Lite
| keep.depth = FALSE, | ||
| output.file = NULL, | ||
| vcf_header = NULL, | ||
| reference = NULL) { |
| ploidy = 2L, | ||
| vcf_header = NULL, | ||
| reference = NULL, | ||
| align_indels = TRUE, | ||
| asSNPs = FALSE, | ||
| verbose = TRUE) { |


Introduces options to the VCF conversion functions so that users can edit the reference genome and header information for the output VCF.