Repository navigation
fix: escape device fields in the Monitor list view - #279
Open
somethingwithproof wants to merge 3 commits into
Open
somethingwithproof wants to merge 3 commits into
somethingwithproof wants to merge 3 commits into
Conversation
TheWitness
requested changes
Oct 23, 2026
TheWitness
left a comment
Member
There was a problem hiding this comment.
Use ecell() instead of html_escape()
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/escape-list-view-fields
branch
from
October 24, 2026 14:45
d9be7ca to
90e9d2c
Compare
Member
Author
|
Switched the four fields to form_selectable_ecell() and rebased onto develop. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The List view printed the device description, location, site name and Monitor Text without the escaping the other Monitor views apply.
form_selectable_cell()outputs its argument as-is, so a name containing characters like<or&was displayed wrongly. This wraps those four fields inhtml_escape()inrenderHostList(), so the List view matches the Tiles, Tree and Names views.Related Issue
None.
Motivation and Context
The List view was the only view that did not escape these fields.
How Has This Been Tested?
Added a Pest test that renders a List row for a device whose description, location, site name and Monitor Text contain
<,&and quotes, and checks for the escaped form. It fails without the change and passes with it. The full suite passes (123 tests).Screenshots (if appropriate):
Types of changes
Checklist: