feat: add Cap Pro Loom concierge migration by richiemcilroy · Pull Request #2326 · CapSoftware/Cap

richiemcilroy · 2026-09-21T10:46:49Z

Summary

Cap Pro customers can request a free concierge Loom migration from the dashboard. The page covers the self-service CSV steps and the Loom invite, and shows pending, in-progress, information-needed and complete states.
A staff-only queue (/dashboard/admin/loom-migrations) imports customer videos through the existing Loom workflow, with a restricted MP4 upload path for videos Loom won't serve.
Completion requires a verified agreed source count, matching Cap count, and no unfinished imports for the request. An expiring import lease lets an interrupted action recover.

Update for current main

Merged main (about 1,350 commits). Regenerated the schema as a single additive migration, 0050_loom_concierge, chained from main's 0049 snapshot. It only creates loom_migration_requests and loom_migration_imports.
Dropped the emails/ catalog edits, since that directory moved to the marketing repo. The transactional templates stay in packages/database/emails.
Restricted MP4 uploads now use getNewVideoPublic, so they respect an organization's private-by-default sharing.
Concierge actions return expected failures as { ok: false, error } instead of throwing. Production builds hide thrown server-action messages, so operators and customers would otherwise see a generic error instead of "imports are still processing" or "reconcile the count".
Starting an import moves only pending requests to in_progress. It no longer clears an open "Information needed" question.
Customers are emailed only when the status or message changes, not on count-only edits.
Status colours now use palette tokens that exist. The operator message resets when the status changes, so completion doesn't resend an old question.

Validation

Typecheck, Biome on the changed files, and all 63 Loom tests (52 unit, 11 integration).
New __tests__/integration/loom-concierge-database.test.ts runs against real MySQL and S3-compatible storage when CAP_LOOM_CONCIERGE_TEST_DATABASE_URL is set, and skips otherwise. It covers Pro, role and operator access, the one-active-request rule, the information round trip, CSV mapping and duplicates, lease contention and expiry, completion gating, presigned MP4 upload to MinIO, private default visibility, and cross-request isolation.
Applied every migration, 0000 through 0050, to a fresh MySQL 8 database.
Headless browser walkthrough against a local dev server, 23/23 checks:
- Customer request, invite and answer.
- Operator validation, CSV failure reporting and MP4 upload. The local media server produced result.mp4, a screenshot and a preview, and the video landed in its Cap space.
- Completion is blocked while processing and succeeds afterwards. The queue empties and the customer sees "complete".
- Free owners see the Pro requirement, members don't see the concierge card, and customers get a 404 on the operator queue.
The share-stage-identity unit failures also happen on main and are unrelated.

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness or repository-rule issues identified in the latest changes.

Summary

The PR adds a Cap Pro Loom concierge migration workflow for customers and staff, including request tracking, CSV-based imports, restricted MP4 uploads, status notifications, import reservations, and database-backed reconciliation.

Adds customer-facing migration request and status pages.
Adds a restricted operator queue for mapped CSV and MP4 imports.
Tracks imported videos per migration request and prevents completion while mapped work remains unfinished.
Adds renewable import leases to recover safely from interrupted actions.
Adds schema migrations, email templates, documentation, and focused unit tests.

_{Reviews (7) · Last reviewed commit: "fix: account for long Loom concierge imp..."}

richiemcilroy · 2026-09-21T10:52:48Z

hey @greptileai, please re-review the PR

richiemcilroy · 2026-09-21T11:01:57Z

hey @greptileai, please re-review the PR

richiemcilroy · 2026-09-21T11:08:27Z

hey @greptileai, please re-review the PR

richiemcilroy · 2026-09-21T11:17:33Z

hey @greptileai, please re-review the PR

richiemcilroy · 2026-09-21T11:19:52Z

hey @greptileai, please re-review the PR

richiemcilroy · 2026-09-21T11:25:34Z

hey @greptileai, please re-review the PR

…questions

… message on status change

vercel · 2026-10-20T16:10:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
cap-status	Skipped		Oct 20, 2026 5:22pm UTC

richiemcilroy · 2026-10-20T16:10:38Z

hey @greptileai, please re-review the PR

capy-ai

Capy found 3 potential issues (3 medium).

capy-ai · 2026-10-20T16:17:04Z

+				eq(loomMigrationRequests.id, requestId),
+				eq(loomMigrationRequests.status, request.status),
+				isNotNull(loomMigrationRequests.activeOrganizationId),
+				nextStatus === "completed"
+					? or(
+							eq(loomMigrationRequests.activeImportCount, 0),
+							lte(loomMigrationRequests.activeImportLeaseUntil, new Date()),


Completion can miss imports created after its unfinished-work check

Medium Severity

For an in-progress request, the unfinished-import query can return empty, then a concurrent CSV import or restricted-upload preparation can reserve the request, insert a mapped uploading video, and release its reservation before this UPDATE runs. The status remains in_progress and activeImportCount is back to zero, so both guards pass despite the newly unfinished work. The customer receives a completion notice and the request leaves the queue; a prepared MP4 upload can no longer be finalized because its request is inactive. Lock the request across the unfinished-work check and completion update, or use a version guard that also detects intervening imports.

Fixed in 5efae8d. Completion now locks the request row (FOR UPDATE), re-checks status and the import lease, and checks unfinished imports with a locking read, all in one transaction. Import paths take the same row lock before they insert mapped work, so they serialize. The new integration test holds an import transaction open while completion runs. It completes on the old code and is blocked on the new code.

capy-ai · 2026-10-20T16:17:05Z

+				!existing.ownerId ||
+				!existing.ownerEmail ||
+				normalizeImportEmail(existing.ownerEmail) !== normalizedEmail ||
+				!existing.rawFileKey ||


Failed automatic imports cannot use MP4 recovery

Medium Severity

The automatic-import path in importLoomVideoForOwner creates videoUploads without rawFileKey, and importLoomVideoWorkflow never persists that key. If a concierge CSV import later reaches phase error, this new recovery path rejects it because existing.rawFileKey is null, even with the correct owner and an authorized MP4. Retrying the CSV also rejects the existing video, while completion rejects its mapped error record. Persist or safely derive the automatic import's raw-file key so the operator can recover it without deleting the video or editing database records.

Fixed in 5efae8d. For an errored automatic import with no stored rawFileKey, the restricted-upload path derives the same key the import workflow writes ({ownerId}/{videoId}/raw-upload.mp4). It saves the key on the upload row inside the lease-checked transaction, so finishing the upload works. An integration test covers recovering a failed CSV import through the MP4 path end to end.

capy-ai · 2026-10-20T16:17:05Z

+					}),
+				);
+				started += result.importedCount;
+				failures.push(...result.results.filter((row) => !row.success));


The operator queue discards space-mapping failures

Medium Severity

When space creation, video assignment, or owner membership fails after an import starts, processLoomCsvRows returns success: true together with an error explaining the failed mapping. This filter discards those rows, so the new operator queue reports zero rows needing review and never displays the warning. The video can finish outside its requested space or without the required membership, and retrying the CSV refuses it as already imported. Retain and display rows with errors even when their video import started, distinguishing mapping failures from failed starts.

Fixed in 5efae8d. The queue now keeps rows that started but returned an error, counts them separately ("started rows need space mapping"), and lists them with their requested space.

…, and surface unmapped rows

capy-ai

Capy found no issues.

richiemcilroy · 2026-10-20T17:21:25Z

hey @greptileai, please re-review the PR

capy-ai

Capy found no issues.

feat: add Cap Pro Loom concierge migration

1f15dc3

vercel Bot deployed to Preview September 21, 2026 10:47

View deployment

greptile-apps Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread apps/web/actions/loom-concierge.tsx Outdated

Comment thread apps/web/actions/loom-concierge.tsx Outdated

fix: register Loom migration emails

8df6730

vercel Bot deployed to Preview September 21, 2026 10:53

View deployment

fix: coordinate concierge import completion

1b6cb9d

vercel Bot deployed to Preview September 21, 2026 11:02

View deployment

fix: cover Loom concierge link in importer fixture

e9fb851

greptile-apps Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread apps/web/lib/loom-concierge.ts Outdated

Comment thread apps/web/__tests__/unit/loom-csv.test.ts Outdated

vercel Bot deployed to Preview September 21, 2026 11:08

View deployment

fix: recover interrupted Loom concierge imports

5260526

vercel Bot deployed to Preview September 21, 2026 11:17

View deployment

fix: validate Loom video IDs in server requests

0f4fe25

vercel Bot deployed to Preview September 21, 2026 11:20

View deployment

greptile-apps Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread apps/web/lib/loom-concierge.ts

fix: account for long Loom concierge imports

5b2bc8a

vercel Bot deployed to Preview September 21, 2026 11:26

View deployment

richiemcilroy added 5 commits October 20, 2026 23:43

Merge main into Loom concierge migration

6da1d73

fix: show Loom concierge errors in production and keep open customer …

7185eec

…questions

test: cover Loom concierge migration against MySQL and S3

d5e6a5d

fix: use defined colours for Loom migration status and reset operator…

19bfa8b

… message on status change

chore: keep migration journal formatting consistent

2ed1092

vercel Bot deployed to Preview – cap-status October 20, 2026 16:10

View deployment

vercel Bot deployed to Preview – cap-web October 20, 2026 16:12

View deployment

capy-ai Bot reviewed Oct 20, 2026

View reviewed changes

fix: lock Loom concierge completion, recover failed automatic imports…

5efae8d

…, and surface unmapped rows

vercel Bot temporarily deployed to Preview – cap-status October 20, 2026 16:23 Inactive

vercel Bot deployed to Preview – cap-web October 20, 2026 16:25

View deployment

capy-ai Bot reviewed Oct 20, 2026

View reviewed changes

fix: make Loom migration status email read correctly for every status

bead736

vercel Bot temporarily deployed to Preview – cap-status October 20, 2026 17:22 Inactive

vercel Bot deployed to Preview – cap-web October 20, 2026 17:24

View deployment

capy-ai Bot reviewed Oct 20, 2026

View reviewed changes

richiemcilroy merged commit 4e400a9 into main Oct 20, 2026
39 checks passed

Conversation

richiemcilroy commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Update for current main

Validation

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

richiemcilroy commented Sep 21, 2026

Uh oh!

richiemcilroy commented Sep 21, 2026

Uh oh!

Uh oh!

Uh oh!

richiemcilroy commented Sep 21, 2026

Uh oh!

richiemcilroy commented Sep 21, 2026

Uh oh!

richiemcilroy commented Sep 21, 2026

Uh oh!

Uh oh!

richiemcilroy commented Sep 21, 2026

Uh oh!

vercel Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richiemcilroy commented Oct 20, 2026

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot Oct 20, 2026

Choose a reason for hiding this comment

Completion can miss imports created after its unfinished-work check

Uh oh!

richiemcilroy Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot Oct 20, 2026

Choose a reason for hiding this comment

Failed automatic imports cannot use MP4 recovery

Uh oh!

richiemcilroy Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot Oct 20, 2026

Choose a reason for hiding this comment

The operator queue discards space-mapping failures

Uh oh!

richiemcilroy Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

richiemcilroy commented Oct 20, 2026

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

richiemcilroy commented Sep 21, 2026 •

edited

Loading

vercel Bot commented Oct 20, 2026 •

edited

Loading