Repository navigation
fix(desktop): return store errors for stale resource IDs - #2768
Closed
richiemcilroy wants to merge 1 commit into
Closed
richiemcilroy wants to merge 1 commit into
richiemcilroy wants to merge 1 commit into
Conversation
|
Found 1 test failure on Blacksmith runners: Failure
|
Member
Author
|
Closing as part of the post-0.6.1 PR cleanup: Tauri: vendors tauri-plugin-store 2.4.0 with a stale-resource-ID backport; only the Tauri app uses tauri-plugin-store, GPUI does not depend on it |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a Tauri settings store after its resource has been removed panics in the plugin's cached-ID lookup. Return
BadResourceIdthrough the existingResultinstead, so the caller can handle the failure and subsequent lookups do not encounter a poisoned store registry.Backports tauri-apps/plugins-workspace#3157 onto the vendored 2.4.0 plugin. The first fixed release, 2.4.2, requires Tauri 2.9.3; this keeps Cap's locked Tauri 2.8.5 and all existing runtime dependency versions. The copied upstream runtime sources differ only at that lookup. Generated upstream JavaScript and schema files stay byte-for-byte unchanged and are excluded from Biome.
The regression uses the real plugin with Tauri's mock runtime: load and save a store, clear resources with
cleanup_before_exit, then perform repeated lookups and verify the saved bytes are unchanged. A separate test covers normal close/reopen behavior. Both tests now run in the existing Windows and macOS CI jobs.Validation:
libavutil.pc) in the Linux environment.next).eaa5bcbb5e30ea247d7ca9ba61149a1803f1efdf, CI passed, including Windows/macOS store lifecycle regressions and Clippy, Typecheck, and all GPUI desktop jobs. Real-capture verification, Windows Target Discovery, and Perf budget also passed.fragment-spancases. The engine/muxer dependency and feature graphs match base and do not include Tauri/store; the same cases failed in an earlier run before this patch. Its automatic retry reproduced both failures. No recording tests or bounds were changed.This hardens the retained Tauri app used by 0.6.0. Current GPUI release code does not use this store plugin. Resource cleanup is a reproduced cause of this panic; the production event's precise lifecycle trigger remains unconfirmed.