Repository navigation
Fix 61019 - #140
Merged
Merged
Fix 61019#140
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Retry handling can expose private descriptions by reusing a public task after visibility changes and falsely report success without a valid comment ID, risking lost drafts and skipped attachments.
2 open issues
What changed in this PR
This PR updates the Spotfix widget’s task creation, sharing, and navigation flows for task 61019.
Changes:
- Adds description validation, initial-comment retries, and draft cleanup after successful creation.
- Adds direct spot links and improves page-link display and menu navigation.
- Normalizes editor iframe sizing and updates the distribution bundle.
| File | Description |
|---|---|
styles/doboard-widget.css |
Adds sizing and positioning overrides for editor iframes. |
js/src/widget.js |
Updates task metadata, draft cleanup, links, and menu handling. |
js/src/main.js |
Supports opening spots from task-level URL fragments. |
js/src/loaders/SpotFixTemplatesLoader.js |
Adds spot links to menus and updates page-link tooltips. |
js/src/handlers.js |
Adds validation, comment retries, and shared link helpers. |
dist/doboard-widget-bundle.js |
Includes the corresponding source and style changes. |
Review effort: Balanced
| for (let attempt = 1; attempt <= SPOTFIX_INITIAL_COMMENT_ATTEMPTS; attempt++) { | ||
| try { | ||
| result.initialComment = await addTaskComment(commentParams, result.taskId, taskDetails.taskDescription + sign); | ||
| if (result.initialComment) { |
There was a problem hiding this comment.
🟡 Changes recommended
Comment retries can duplicate saved descriptions after ambiguous failures, while treating a missing comment ID as success can clear drafts and skip attachments even though the description was not saved.
2 open issues
1 resolved since last review
Review effort: Balanced
Comment on lines
+156
to
+158
| for (let attempt = 1; attempt <= SPOTFIX_INITIAL_COMMENT_ATTEMPTS; attempt++) { | ||
| try { | ||
| result.initialComment = await addTaskComment(commentParams, result.taskId, taskDetails.taskDescription + sign); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/61019