Skip to content

fix(client-v2): format Duration nanos with Locale.ROOT in durationToTimeString #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcbeingused333 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(client-v2): format Duration nanos with Locale.ROOT in durationToTimeString #3310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client-v2/src/main/java/com/clickhouse/client/api/DataTypeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ public static String durationToTimeString(Duration duration, int precision) {
if (precision > 0 && precision <= 9) {
sb.append('.');
// Format nanos with leading zeros, then truncate to precision
String nanosStr = String.format("%09d", nanos);
String nanosStr = String.format(java.util.Locale.ROOT, "%09d", nanos);
sb.append(nanosStr, 0, precision);
}

Expand Down
12 changes: 12 additions & 0 deletions client-v2/src/test/java/com/clickhouse/client/api/DataTypeUtilsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,4 +501,16 @@ void testRoundTripConversionsWithDifferentTimezones() {
assertEquals(dateTimeInNy.toLocalDate(), LocalDate.of(2024, 7, 4).minusDays(1),
"Same instant should be previous day in New York");
}

@Test(groups = {"unit"})
public void testDurationToTimeStringIgnoresDefaultLocale() {
java.util.Locale original = java.util.Locale.getDefault();
try {
java.util.Locale.setDefault(java.util.Locale.forLanguageTag("fa-IR"));
assertEquals(DataTypeUtils.durationToTimeString(Duration.ofSeconds(3661, 123456789), 9), "1:01:01.123456789");
assertEquals(DataTypeUtils.durationToTimeString(Duration.ofSeconds(1, 5000000), 3), "0:00:01.005");
} finally {
java.util.Locale.setDefault(original);
}
}
}
1 change: 1 addition & 0 deletions history/latest/3308.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- **[client-v2, jdbc-v2]** Fixed `Duration`/`Time64` parameter rendered with non-ASCII digits under locales like fa-IR/ar-SA (`String.format` used the default locale); now `Locale.ROOT`. (https://github.com/ClickHouse/clickhouse-java/issues/3308)