Skip to content

Manchester | 26-ITP-Sept | Fatima Rouchi | Sprint 2 | Practice TDD - #1758

Open
fatimarouchi wants to merge 4 commits into
CodeYourFuture:mainfrom
fatimarouchi:coursework/sprint-3-practice-tdd-clean
Open

fatimarouchi wants to merge 4 commits into
CodeYourFuture:mainfrom
fatimarouchi:coursework/sprint-3-practice-tdd-clean

Conversation

@fatimarouchi

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

CYF-1060

@fatimarouchi fatimarouchi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 26, 2026
@hey-hammad hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 28, 2026

@hey-hammad hey-hammad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work overall, a few test cases needs attention and bug in the count.js needs to be resolved. Thanks

Comment thread practice-tdd/count.test.js Resolved
Comment thread practice-tdd/count.test.js Resolved
Comment thread practice-tdd/get-ordinal-number.test.js Resolved
@hey-hammad hey-hammad added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 28, 2026
@fatimarouchi fatimarouchi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants