Repository navigation
675 mirror #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Droid-An
wants to merge
24
commits into
CodeYourFuture:main
Choose a base branch
from
Droid-An:675-mirror
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
675 mirror #17
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4350f48
Fix expected output in sed exercise instructions (#353)
Abubakar-Meigag 743e491
Automate testing of initial sprints in tools module (#472)
LonMcGregor f38fee5
Make test-sdc script more portable (#520)
illicitonion ab33fa5
Add automated tests for cowsay implementation (#521)
illicitonion d3857c2
Improve cowsay comments (#522)
illicitonion 47e4131
switching last two hex questions (#533)
Poonam-raj 3f26722
Add more expected test cases for ls implementations (#441)
illicitonion 78bdfd5
cat implemented
Alex-Jamshidi 60b323e
cat updated
Alex-Jamshidi 3a35a7a
wc implemented
Alex-Jamshidi 085224e
ls complete
Alex-Jamshidi b28f41d
remove unused code
Alex-Jamshidi 7d6a298
updated eronious boolean in ls
Alex-Jamshidi fce72f0
updated ls so that data doesn't rely on global variables and is passe…
Alex-Jamshidi 14d4d33
updated flag a
Alex-Jamshidi 2b981ed
collapsed getuserargs function
Alex-Jamshidi fa7436b
rearranged some argument orders in ls
Alex-Jamshidi d4720b1
added comments to ls
Alex-Jamshidi 5c64429
further added comments to ls
Alex-Jamshidi 769706f
wc refactored
Alex-Jamshidi 65e60ae
refactored cat
Alex-Jamshidi efdd20b
updated getcwd
Alex-Jamshidi 61a6eaa
Add .venv to gitignore
Alex-Jamshidi eeb4d7a
removed implement shell tools files
Alex-Jamshidi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| node_modules | ||
| testoutput.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| ________________ | ||
| | Grass, delicious | | ||
| ================ | ||
| \ | ||
| \ | ||
| ^__^ | ||
| (oo)\_______ | ||
| (__)\ )\/\ | ||
| ||----w | | ||
| || || |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| ______________ | ||
| | Fish are cool! | | ||
| ============== | ||
| \ | ||
| \ | ||
| \ | ||
| \ | ||
| ___-------___ | ||
| _-~~ ~~-_ | ||
| _-~ /~-_ | ||
| /^\__/^\ /~ \ / \ | ||
| /| O|| O| / \_______________/ \ | ||
| | |___||__| / / \ \ | ||
| | \ / / \ \ | ||
| | (_______) /______/ \_________ \ | ||
| | / / \ / \ | ||
| \ \^\\ \ / \ / | ||
| \ || \______________/ _-_ //\__// | ||
| \ ||------_-~~-_ ------------- \ --/~ ~\ || __/ | ||
| ~-----||====/~ |==================| |/~~~~~ | ||
| (_(__/ ./ / \_\ \. | ||
| (_(___/ \_____)_) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed | ||
| Basia | ||
| Mehmet | ||
| Leila | ||
| Piotr | ||
| Chandra |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed London | ||
| Basia London | ||
| Mehmet Birmingham | ||
| Leila London | ||
| Piotr Glasgow | ||
| Chandra Birmingham |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed 1 | ||
| Basia 22 | ||
| Mehmet 3 | ||
| Leila 1 | ||
| Piotr 15 | ||
| Chandra 12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Ahmed 4 | ||
| Basia 6 | ||
| Leila 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed 3 | ||
| Basia 3 | ||
| Mehmet 3 | ||
| Leila 1 | ||
| Piotr 5 | ||
| Chandra 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed 15 | ||
| Basia 37 | ||
| Mehmet 32 | ||
| Leila 1 | ||
| Piotr 61 | ||
| Chandra 18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Once upon a time... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Once upon a time... | ||
| There was a house made of gingerbread. | ||
| It looked delicious. | ||
| I was tempted to take a bite of it. | ||
| But this seemed like a bad idea... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| 1 It looked delicious. | ||
| 2 I was tempted to take a bite of it. | ||
| 3 But this seemed like a bad idea... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| 1 Once upon a time... | ||
| 2 There was a house made of gingerbread. | ||
| 3 It looked delicious. | ||
| 4 I was tempted to take a bite of it. | ||
| 5 But this seemed like a bad idea... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Doctor: Hello | ||
| Doctor: What's wrong today? | ||
| Doctor: That sounds frustrating. When did this start? | ||
| Doctor: Say "Hi". | ||
| Doctor: You didn't say hello | ||
| Doctor: You're welcome, goodbye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| Doctor: Hello | ||
| Patient: Hello Doctor | ||
| Doctor: What's wrong today? | ||
| Doctor: That sounds frustrating. When did this start? | ||
| Doctor: Say "Hi". | ||
| Doctor: You didn't say hello | ||
| Doctor: You're welcome, goodbye | ||
| Patient: I went to the doctor! | ||
| Spouse: I'm glad you saw the Doctor: did they cure you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| Doctor: What's wrong today? | ||
| Doctor: That sounds frustrating. When did this start? | ||
| Doctor: Say "Hi". | ||
| Patient: Hi | ||
| Patient: I seem to be cured! | ||
| Doctor: You're welcome, goodbye | ||
|
|
||
| Patient: I went to the doctor! | ||
| Spouse: I'm glad you saw the Doctor: did they cure you? | ||
| Patient: Yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Doctor: You didn't say hello | ||
| Patient: I seem to be cured! | ||
| -- | ||
| Patient: I went to the doctor! | ||
| Spouse: I'm glad you saw the Doctor: did they cure you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| dialogue-2.txt | ||
| dialogue.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| dialogue-2.txt:2 | ||
| dialogue-3.txt:0 | ||
| dialogue.txt:6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| child-directory | ||
| script-01.sh | ||
| script-02.sh | ||
| script-03.sh | ||
| script-04.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| helper-1.txt | ||
| helper-2.txt | ||
| helper-3.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| .: | ||
| child-directory | ||
| script-01.sh | ||
| script-02.sh | ||
| script-03.sh | ||
| script-04.sh | ||
|
|
||
| ./child-directory: | ||
| helper-1.txt | ||
| helper-2.txt | ||
| helper-3.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| First exercise (sorted newest to oldest): | ||
| helper-3.txt | ||
| helper-1.txt | ||
| helper-2.txt | ||
| Second exercise (sorted oldest to newest): | ||
| helper-2.txt | ||
| helper-1.txt | ||
| helper-3.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| ThIs Is a sample fIle for experImentIng wIth sed. | ||
|
|
||
| It contaIns many lInes, and there are some thIngs you may want to do wIth each of them. | ||
|
|
||
| We'll Include some score InformatIon: | ||
| 37 AlIsha | ||
| 15 Jacob | ||
| 7 PIetro | ||
| 3 Katya | ||
|
|
||
| We also should remember, when we go shoppIng, to get 4 Items: oranges,cheese,bread,olIves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| This is a sample file for experimenting with sed. | ||
|
|
||
| It contains many lines, and there are some things you may want to do with each of them. | ||
|
|
||
| We'll include some score information: | ||
| Alisha | ||
| Jacob | ||
| Pietro | ||
| Katya | ||
|
|
||
| We also should remember, when we go shopping, to get items: oranges,cheese,bread,olives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| This is a sample file for experimenting with sed. | ||
|
|
||
| It contains many lines, and there are some things you may want to do with each of them. | ||
|
|
||
| We'll include some score information: | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| This is a sample file for experimenting with sed. | ||
|
|
||
| It contains many lines, and there are some things you may want to do with each of them. | ||
|
|
||
| We'll include some score information: | ||
| 37 Alisha | ||
| 15 Jacob | ||
| 7 Pietro | ||
| 3 Katya | ||
|
|
||
| We also should remember, when we go shopping, to get 4 items: oranges,cheese,bread,olives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| This is a sample file for experimenting with sed. | ||
|
|
||
| It contains many lines, and there are some things you may want to do with each of them. | ||
|
|
||
| We'll include some score information: | ||
| Alisha 37 | ||
| Jacob 15 | ||
| Pietro 7 | ||
| Katya 3 | ||
|
|
||
| We also should remember, when we go shopping, to get 4 items: oranges,cheese,bread,olives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| This is a sample file for experimenting with sed. | ||
|
|
||
| It contains many lines, and there are some things you may want to do with each of them. | ||
|
|
||
| We'll include some score information: | ||
| 37 Alisha | ||
| 15 Jacob | ||
| 7 Pietro | ||
| 3 Katya | ||
|
|
||
| We also should remember, when we go shopping, to get 4 items: oranges, cheese, bread, olives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 19 ../helper-files/helper-3.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3 ../helper-files/helper-3.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| 1 4 20 ../helper-files/helper-1.txt | ||
| 1 7 39 ../helper-files/helper-2.txt | ||
| 3 19 92 ../helper-files/helper-3.txt | ||
| 5 30 151 total |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Selma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 35 Fashion Street, London, E1 6PX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Selma, Software Engineer | ||
| Selma, Software Engineer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed | ||
| Basia | ||
| Mehmet | ||
| Leila | ||
| Piotr | ||
| Chandra |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed London | ||
| Basia London | ||
| Mehmet Birmingham | ||
| Leila London | ||
| Piotr Glasgow | ||
| Chandra Birmingham |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed 1 | ||
| Basia 22 | ||
| Mehmet 3 | ||
| Leila 1 | ||
| Piotr 15 | ||
| Chandra 12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed 4 | ||
| Basia 6 | ||
| Mehmet 17 | ||
| Leila 1 | ||
| Piotr 8 | ||
| Chandra 6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed 3 | ||
| Basia 3 | ||
| Mehmet 3 | ||
| Leila 1 | ||
| Piotr 5 | ||
| Chandra 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Ahmed 15 | ||
| Basia 37 | ||
| Mehmet 32 | ||
| Leila 1 | ||
| Piotr 61 | ||
| Chandra 18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"answers": [0, 1110, 45, 1000, "01011", 11111, 100010, 15, 8, 2, "(10$|10[^0-9])", "E", 182, 902, 11, 33]} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| Ariane | ||
| Daniel | ||
| HoChiMinh | ||
| KualaLumpur | ||
| Levi | ||
| London | ||
| NewYork | ||
| Niamh | ||
| Olga | ||
| York | ||
| dHondt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| Ariane | ||
| Daniel | ||
| HoChiMinh | ||
| KualaLumpur | ||
| Levi | ||
| London | ||
| NewYork | ||
| Niamh | ||
| Olga | ||
| York |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the new
test_sdc_tasksjob, the same or very similar long boolean expressions are repeated in multipleif:conditions (for example, the list ofsteps.*.outputs.attemptedchecks inmake output commentandfail if not complete, and the list ofsteps.*.outputs.completechecks inadd appropriate labels).This isn’t a functional bug, but it does mean that whenever you add or remove a task (e.g. another directory to test), you’d need to remember to update several separate
if:expressions in exactly the same way. That’s often how inconsistencies creep in over time.Would it be possible to centralise the notion of "any task attempted" and "any task complete" using a single step whose output you reuse, or by grouping these conditions in one place (for example via a small helper step that sets a combined output flag)? That way, adding a new task would only require updating one location, and the job-level conditions would stay in sync automatically.
To "like" or "dislike" this comment, please follow this link